Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1773323002: Fix IPC fuzzer ChannelMojo usage (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
Sam McNally, Nico
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IPC fuzzer ChannelMojo usage R=thakis@chromium.org,sammc@chromium.org BUG= TBR=jam@chromium.org for content Committed: https://crrev.com/cf739d070a7d45cab64b4b6fd8e9cf085ea45a42 Cr-Commit-Position: refs/heads/master@{#380006}

Patch Set 1 #

Total comments: 1

Patch Set 2 : do things more better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M content/public/common/mojo_channel_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 5 chunks +31 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-08 22:40:07 UTC) #1
Nico
lgtm stamp, thanks!
4 years, 9 months ago (2016-03-08 22:43:41 UTC) #2
Sam McNally
LGTM, but it looks like https://codereview.chromium.org/1776753002 got here first. (My fix got bogged down in ...
4 years, 9 months ago (2016-03-08 22:49:04 UTC) #4
Ken Rockot(use gerrit already)
On 2016/03/08 at 22:49:04, sammc wrote: > LGTM, but it looks like https://codereview.chromium.org/1776753002 got here ...
4 years, 9 months ago (2016-03-08 23:48:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773323002/20001
4 years, 9 months ago (2016-03-08 23:49:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 01:03:47 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 01:05:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf739d070a7d45cab64b4b6fd8e9cf085ea45a42
Cr-Commit-Position: refs/heads/master@{#380006}

Powered by Google App Engine
This is Rietveld 408576698