Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3173)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm

Issue 17733005: [Autofill] (Mostly) fix Autofill popup positioning on multiple monitors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
index 18a41964d60739e434a33e324d34d5d91949c12a..cf1b5a72eeb704719c2f059680526acb04d20fdb 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
@@ -93,9 +93,7 @@ void AutofillPopupViewBridge::UpdateBoundsAndRedrawPopup() {
NSRect frame = NSRectFromCGRect(controller_->popup_bounds().ToCGRect());
// Flip coordinates back into Cocoa-land.
Scott Hess - ex-Googler 2013/06/27 21:55:58 OK, per offline discussion, I think I see what you
Ilya Sherman 2013/06/28 00:51:16 Done.
- // TODO(isherman): Does this agree with the controller's idea of handling
- // multi-monitor setups correctly?
- NSScreen* screen = [[controller_->container_view() window] screen];
+ NSScreen* screen = [[NSScreen screens] objectAtIndex:0];
frame.origin.y = NSHeight([screen frame]) - NSMaxY(frame);
// Leave room for the border.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698