Cleanup: media_stream_api.* ==> media_stream_utils.*

Cleanup: media_stream_api.* ==> media_stream_utils.*

TEST=all unittests and LayoutTests passing.

Committed: https://crrev.com/034e5740050e5e9f23563e3d19a8a7d0ebff0a12
Cr-Commit-Position: refs/heads/master@{#382026}

[mcasas, 2016-03-10 20:20:40]

mcasas@chromium.org changed reviewers:
+ miu@chromium.org

[mcasas, 2016-03-10 20:20:41]

miu@ PTAL
(assuming all bots green).

[mcasas, 2016-03-11 23:23:54]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org

[mcasas, 2016-03-11 23:23:55]

emircan@ PTAL

[miu, 2016-03-11 23:55:00]

lgtm, assuming a src/content owner is on-board with this name change.  I think
"api" was in the name because originally only src/chrome code called these
functions (i.e., these were viewed as "libcontent" external APIs).

[emircan, 2016-03-12 00:41:21]

lgtm

[mcasas, 2016-03-12 01:54:27]

mcasas@chromium.org changed reviewers:
+ tommi@chromium.org

[mcasas, 2016-03-12 01:54:27]

tommi@ rote change please indicate if you agree

[mcasas, 2016-03-16 18:51:12]

On 2016/03/12 01:54:27, mcasas wrote:
> tommi@ rote change please indicate if you agree

ping tommi@

[tommi (sloooow) - chröme, 2016-03-16 19:01:11]

lgtm with one request

https://codereview.chromium.org/1773273007/diff/1/content/public/renderer/med...
File content/public/renderer/media_stream_utils.h (right):

https://codereview.chromium.org/1773273007/diff/1/content/public/renderer/med...
content/public/renderer/media_stream_utils.h:41:
scoped_refptr<media::AudioCapturerSource> audio_source,
this should be by const & or pass a pointer to media::AudioCapturerSource as per
recent discussion on chromium-dev.

[mcasas, 2016-03-18 01:41:29]

https://codereview.chromium.org/1773273007/diff/1/content/public/renderer/med...
File content/public/renderer/media_stream_utils.h (right):

https://codereview.chromium.org/1773273007/diff/1/content/public/renderer/med...
content/public/renderer/media_stream_utils.h:41:
scoped_refptr<media::AudioCapturerSource> audio_source,
On 2016/03/16 19:01:11, tommi-chromium wrote:
> this should be by const & or pass a pointer to media::AudioCapturerSource as
per
> recent discussion on chromium-dev.

Added a TODO: it's beyond the reach of this CL
since it affects also callers and callees [1].

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...


Correction: I know the discussion you're talking
about but I read this in the Chromium StyleGuide:

"If the function (at least sometimes) takes a ref
on a refcounted object, declare the param as 
scoped_refptr<T>. The caller can decide whether it 
wishes to transfer ownership (by calling std::move(t)
when passing t) or retain its ref (by simply 
passing t directly)."

https://www.chromium.org/developers/coding-style#TOC-Object-ownership-and-cal...

In that sense the current signature is correct.

More interesting is that the AudioCapturerSource
is a scoped_refptr<> but I took a first look and
seems like it could be scoped_ptr<> instead.

So I'll commit like this, please let me know if
you'd still like me to write a TODO and/or follow up.

[mcasas, 2016-03-18 01:44:43]

Patchset #2 (id:20001) has been deleted

[mcasas, 2016-03-18 01:44:47]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-03-18 01:44:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
emircan@chromium.org, tommi@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1773273007/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-18 01:45:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773273007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773273007/40001

[mcasas, 2016-03-18 01:50:06]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-03-18 01:51:51]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org, rdevlin.cronin@chromium.org

[mcasas, 2016-03-18 01:51:52]

avi@ RS content/ plz
devlin: RS
chrome/renderer/extensions/cast_streaming_native_handler.cc
and 
extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc

(mechanical renames)

[Avi (use Gerrit), 2016-03-18 16:31:51]

LGTM

What's the question about the rename?

[Devlin, 2016-03-18 16:49:51]

extensions rs lgtm

[mcasas, 2016-03-18 18:29:33]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-03-18 18:29:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
emircan@chromium.org, avi@chromium.org, tommi@chromium.org,
rdevlin.cronin@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1773273007/#ps60001
(title: "+headers in blink_test_runner.cc")

[commit-bot: I haz the power, 2016-03-18 18:30:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773273007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773273007/60001

[commit-bot: I haz the power, 2016-03-18 18:39:45]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-18 18:41:17]

Description was changed from

==========
Cleanup: media_stream_api.* ==> media_stream_utils.*

TEST=all unittests and LayoutTests passing.
==========

to

==========
Cleanup: media_stream_api.* ==> media_stream_utils.*

TEST=all unittests and LayoutTests passing.

Committed: https://crrev.com/034e5740050e5e9f23563e3d19a8a7d0ebff0a12
Cr-Commit-Position: refs/heads/master@{#382026}
==========

[commit-bot: I haz the power, 2016-03-18 18:41:19]

Patchset 3 (id:??) landed as
https://crrev.com/034e5740050e5e9f23563e3d19a8a7d0ebff0a12
Cr-Commit-Position: refs/heads/master@{#382026}