Move code to register/unregister memory dump provider from blink::initialize/shutdown

Move code to register/unregister memory dump provider from blink::initialize/shutdown

WebCacheMemoryDumpProvider is a core feature, so the initialization/shutdown
should be handled by CoreInitializer.

FontCacheMemoryDumpProvider is a platform features, so the initialization/shutdown
should be handled by Platform::initialize.

BUG=593269
Committed: https://crrev.com/69718c022399c18cae3dbc2e12362adfac5d8b3f
Cr-Commit-Position: refs/heads/master@{#380530}

[haraken, 2016-03-09 12:52:49]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-03-09 12:52:50]

PTAL

[sof, 2016-03-09 16:41:39]

https://codereview.chromium.org/1773273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/exported/Platform.cpp (right):

https://codereview.chromium.org/1773273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/exported/Platform.cpp:72:
platform->registerMemoryDumpProvider(FontCacheMemoryDumpProvider::instance(),
"FontCaches");
Needs a null check (or ~TestingPlatformSupport change)? blink_platform_unittests
are failing on shutdown.

[haraken, 2016-03-10 07:36:17]

On 2016/03/09 16:41:39, sof wrote:
>
https://codereview.chromium.org/1773273004/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/exported/Platform.cpp (right):
> 
>
https://codereview.chromium.org/1773273004/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/exported/Platform.cpp:72:
> platform->registerMemoryDumpProvider(FontCacheMemoryDumpProvider::instance(),
> "FontCaches");
> Needs a null check (or ~TestingPlatformSupport change)?
blink_platform_unittests
> are failing on shutdown.

Fixed. PTAL.

[sof, 2016-03-10 07:40:12]

https://codereview.chromium.org/1773273004/diff/10004/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/exported/Platform.cpp (right):

https://codereview.chromium.org/1773273004/diff/10004/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/exported/Platform.cpp:72:
platform->registerMemoryDumpProvider(FontCacheMemoryDumpProvider::instance(),
"FontCaches");
So what is the status of |platform|, can it be non-null or not? We assume
differently in this method.

[haraken, 2016-03-10 11:19:12]

On 2016/03/10 07:40:12, sof wrote:
>
https://codereview.chromium.org/1773273004/diff/10004/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/exported/Platform.cpp (right):
> 
>
https://codereview.chromium.org/1773273004/diff/10004/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/exported/Platform.cpp:72:
> platform->registerMemoryDumpProvider(FontCacheMemoryDumpProvider::instance(),
> "FontCaches");
> So what is the status of |platform|, can it be non-null or not? We assume
> differently in this method.

I'll land https://codereview.chromium.org/1785483003/ first.

[sof, 2016-03-10 11:51:43]

lgtm once dependent CL has landed.

[haraken, 2016-03-10 14:01:22]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-03-10 14:01:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/1773273004/#ps50001
(title: " ")

[commit-bot: I haz the power, 2016-03-10 14:01:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773273004/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773273004/50001

[commit-bot: I haz the power, 2016-03-10 14:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 14:58:26]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-03-10 23:35:07]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:36:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773273004/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773273004/50001

[commit-bot: I haz the power, 2016-03-11 05:30:15]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-03-11 05:32:22]

Description was changed from

==========
Move code to register/unregister memory dump provider from
blink::initialize/shutdown

WebCacheMemoryDumpProvider is a core feature, so the initialization/shutdown
should be handled by CoreInitializer.

FontCacheMemoryDumpProvider is a platform features, so the
initialization/shutdown
should be handled by Platform::initialize.

BUG=593269
==========

to

==========
Move code to register/unregister memory dump provider from
blink::initialize/shutdown

WebCacheMemoryDumpProvider is a core feature, so the initialization/shutdown
should be handled by CoreInitializer.

FontCacheMemoryDumpProvider is a platform features, so the
initialization/shutdown
should be handled by Platform::initialize.

BUG=593269

Committed: https://crrev.com/69718c022399c18cae3dbc2e12362adfac5d8b3f
Cr-Commit-Position: refs/heads/master@{#380530}
==========

[commit-bot: I haz the power, 2016-03-11 05:32:23]

Patchset 4 (id:??) landed as
https://crrev.com/69718c022399c18cae3dbc2e12362adfac5d8b3f
Cr-Commit-Position: refs/heads/master@{#380530}