Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: src/heap/heap.cc

Issue 1773273002: Add flag to trace object groups (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Simplified the code Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index ad83dfb8c7e02843df2b4851d5e14e5131e1bd2d..1b6014f67218b7a53da5821c43549addb67c0691 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -828,6 +828,9 @@ void Heap::FinalizeIncrementalMarking(const char* gc_reason) {
VMState<EXTERNAL> state(isolate_);
HandleScope handle_scope(isolate_);
CallGCPrologueCallbacks(kGCTypeIncrementalMarking, kNoGCCallbackFlags);
+ if (FLAG_trace_object_groups) {
ulan 2016/03/09 14:37:49 Let's move it in CallGCPrologueCallbacks and we ne
Marcel Hlopko 2016/03/09 17:20:23 Done.
+ isolate_->global_handles()->PrintObjectGroups();
+ }
}
}
incremental_marking()->FinalizeIncrementally();
@@ -1285,6 +1288,9 @@ bool Heap::PerformGarbageCollection(
VMState<EXTERNAL> state(isolate_);
HandleScope handle_scope(isolate_);
CallGCPrologueCallbacks(gc_type, kNoGCCallbackFlags);
+ if (FLAG_trace_object_groups) {
ulan 2016/03/09 14:37:49 See comment above.
Marcel Hlopko 2016/03/09 17:20:23 Done.
+ isolate_->global_handles()->PrintObjectGroups();
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698