Issue 1773183007: Version 5.0.71.15 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1773183007: Version 5.0.71.15 (cherry-pick) (Closed)

Created:
4 years, 9 months ago by Michael Hablich

Modified:
4 years, 9 months ago

Reviewers:
Benedikt Meurer, Jakob Kummerow

CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0

Target Ref:
refs/pending/branch-heads/5.0

Project:
v8

Visibility:
Public.

Version 5.0.71.15 (cherry-pick) Merged 0c35579093dc5e286ad89e5c7bde3aeb355def07 [crankshaft] Fix invalid ToNumber optimization. BUG=chromium:590989 LOG=N R=jkummerow@chromium.org, bmeurer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/65b894ceaf2becead2324fd0b7acd9d8f8b1f72e

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -14 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/crankshaft/hydrogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/crankshaft/hydrogen.cc	View	3 chunks	+5 lines, -7 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-590989-1.js	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-590989-2.js	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

Michael Hablich

4 years, 9 months ago (2016-03-10 13:54:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
65b894ceaf2becead2324fd0b7acd9d8f8b1f72e.