Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1773173005: [crankshaft] Added checks to tail call instructions that we don't have to restore caller doubles. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@tco-turbo-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Added checks to tail call instructions that we don't have to restore caller doubles. TBR=bmeurer@chromium.org BUG=v8:4698 LOG=N Committed: https://crrev.com/24cd6676b0bd7af2fa8e7a6fe85876cafb24ad59 Cr-Commit-Position: refs/heads/master@{#34613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773173005/1
4 years, 9 months ago (2016-03-09 11:38:47 UTC) #2
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-09 11:38:55 UTC) #4
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-09 11:44:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773173005/1
4 years, 9 months ago (2016-03-09 11:50:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12084)
4 years, 9 months ago (2016-03-09 11:53:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773173005/1
4 years, 9 months ago (2016-03-09 11:54:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 11:59:17 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/24cd6676b0bd7af2fa8e7a6fe85876cafb24ad59 Cr-Commit-Position: refs/heads/master@{#34613}
4 years, 9 months ago (2016-03-09 11:59:44 UTC) #17
Benedikt Meurer
4 years, 9 months ago (2016-03-09 18:49:15 UTC) #19
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698