net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc - Issue 1773133002: SameSite: Implement 'Strict'/'Lax' attribute parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc

Issue 1773133002: SameSite: Implement 'Strict'/'Lax' attribute parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ios? Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cookies/parsed_cookie.h ('K') | « net/extras/sqlite/sqlite_persistent_cookie_store.cc ('k') | net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc » ('j') | net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc

diff --git a/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc b/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc

index 4be580b811e8c060c0660680b478fe71de6663fd..4c8e4a38cdd4ef8597159261b6b101a202be99f0 100644

--- a/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc

+++ b/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc

@@ -78,9 +78,10 @@ class SQLitePersistentCookieStorePerfTest : public testing::Test {

GURL gurl("www" + domain_name);

for (int cookie_num = 0; cookie_num < 50; ++cookie_num) {

t += base::TimeDelta::FromInternalValue(10);

- store_->AddCookie(CanonicalCookie(

- gurl, base::StringPrintf("Cookie_%d", cookie_num), "1", domain_name,

- "/", t, t, t, false, false, false, COOKIE_PRIORITY_DEFAULT));

+ store_->AddCookie(

+ CanonicalCookie(gurl, base::StringPrintf("Cookie_%d", cookie_num),

+ "1", domain_name, "/", t, t, t, false, false,

+ COOKIE_SAME_SITE_DEFAULT, COOKIE_PRIORITY_DEFAULT));

}

// Replace the store effectively destroying the current one and forcing it