SameSite: Implement 'Strict'/'Lax' attribute parsing.

net/cookies/cookie_constants.cc

Index: net/cookies/cookie_constants.cc
diff --git a/net/cookies/cookie_constants.cc b/net/cookies/cookie_constants.cc
index 05fe22ea437902b90bfb8729cec551f8687a3af9..d2086fa81aa12a59479aa08881ee026c84f0bb1b 100644
--- a/net/cookies/cookie_constants.cc
+++ b/net/cookies/cookie_constants.cc
@@ -13,6 +13,9 @@ namespace {
 const char kPriorityLow[] = "low";
 const char kPriorityMedium[] = "medium";
 const char kPriorityHigh[] = "high";
+
+const char kSameSiteLax[] = "lax";
+const char kSameSiteStrict[] = "strict";
 }  // namespace

[mmenke, 2016/03/11 18:08:30]

nit:  Add a blank line after the start / before the end of the namespace/ 
(Without any line breaks in between, seems fine to leave those out, but now that
we have one, seems like the start/end of the namespace is as significant as any
other cluster of things inside it)

[Mike West, 2016/03/14 10:18:53]

Done.

 
 NET_EXPORT const std::string CookiePriorityToString(CookiePriority priority) {
@@ -42,4 +45,28 @@ NET_EXPORT CookiePriority StringToCookiePriority(const std::string& priority) {
   return COOKIE_PRIORITY_DEFAULT;
 }
 
+NET_EXPORT const std::string CookieSameSiteToString(CookieSameSite samesite) {

[mmenke, 2016/03/11 18:08:30]

This method isn't used anywhere (Neither is CookiePriorityToString, looks like,
other than in tests, but that's another matter...).  Get rid of it?

[mmenke, 2016/03/11 18:08:30]

Remove all NET_EXPORTs from this file...  They should be with the declaration,
not the definition.

[Mike West, 2016/03/14 10:18:53]

Hrm. You're right. I thought we needed both for serialization somewhere, but
dropping that seems fine as it only ends up happening in tests. I'll give you a
separate CL for the existing method.
Done.

+  switch (samesite) {
+    case COOKIE_SAME_SITE_NONE:
+      return std::string();
+    case COOKIE_SAME_SITE_LAX:
+      return kSameSiteLax;
+    case COOKIE_SAME_SITE_STRICT:
+      return kSameSiteStrict;
+    default:
+      NOTREACHED();
+  }
+  return std::string();
+}
+
+NET_EXPORT CookieSameSite StringToCookieSameSite(const std::string& samesite) {
+  std::string comp = base::ToLowerASCII(samesite);

[mmenke, 2016/03/11 18:08:30]

comp seems to violate the Google style guide.

I'd suggest just using base::EqualsCaseInsensitiveASCII.  Think it's clearer,
and we really don't get much from the difference.

[Mike West, 2016/03/14 10:18:53]

Sure.

+
+  if (comp == kSameSiteLax)
+    return COOKIE_SAME_SITE_LAX;
+  if (comp == kSameSiteStrict)
+    return COOKIE_SAME_SITE_STRICT;
+  return COOKIE_SAME_SITE_DEFAULT;
+}
+
 }  // namespace net