components/signin/core/browser/gaia_cookie_manager_service.cc - Issue 1773133002: SameSite: Implement 'Strict'/'Lax' attribute parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service.cc

Issue 1773133002: SameSite: Implement 'Strict'/'Lax' attribute parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke@ Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_unittest.cc ('k') | content/browser/net/quota_policy_cookie_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/gaia_cookie_manager_service.cc

diff --git a/components/signin/core/browser/gaia_cookie_manager_service.cc b/components/signin/core/browser/gaia_cookie_manager_service.cc

index ecbad16b1a58e284f15a74ac4e26f4263232c425..9ed37994b0b2316311398453fb433da0c1ae6827 100644

--- a/components/signin/core/browser/gaia_cookie_manager_service.cc

+++ b/components/signin/core/browser/gaia_cookie_manager_service.cc

@@ -373,10 +373,10 @@ void GaiaCookieManagerService::TriggerListAccounts() {

void GaiaCookieManagerService::ForceOnCookieChangedProcessing() {

GURL google_url = GaiaUrls::GetInstance()->google_url();

- net::CanonicalCookie cookie(google_url, kGaiaCookieName, "",

- google_url.host(), "", base::Time(), base::Time(),

- base::Time(), false, false, false,

- net::COOKIE_PRIORITY_DEFAULT);

+ net::CanonicalCookie cookie(

+ google_url, kGaiaCookieName, "", google_url.host(), "", base::Time(),

+ base::Time(), base::Time(), false, false,

+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);

OnCookieChanged(cookie, true);

}