SameSite: Implement 'Strict'/'Lax' attribute parsing.

net/cookies/cookie_constants.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_COOKIES_COOKIE_CONSTANTS_H_
 #define NET_COOKIES_COOKIE_CONSTANTS_H_
 
 #include <string>
 
 #include "net/base/net_export.h"
 
 namespace net {
 
 enum CookiePriority {
   COOKIE_PRIORITY_LOW     = 0,
   COOKIE_PRIORITY_MEDIUM  = 1,
   COOKIE_PRIORITY_HIGH    = 2,
   COOKIE_PRIORITY_DEFAULT = COOKIE_PRIORITY_MEDIUM
 };
 
+enum CookieSameSite {

[mmenke, 2016/03/11 18:08:30]

Can we make this an enum class instead?  Seems simpler to do it now rather than
later, and the type safety checks are nifty.

[Mike West, 2016/03/14 10:18:54]

Sure.

+  COOKIE_SAME_SITE_NONE = 0,

[mmenke, 2016/03/11 18:08:30]

SAME_SITE_NONE seems kinda weird as a property of a cookie.  Sounds almost like
we're not sending cookies to the "same site".  Could call it
COOKIE_RESTRICT_SAME_SITE_DISABLED or something...or could keep it as-is.  Just
thought I'd mention the name seems a little weird.

[Mike West, 2016/03/14 10:18:53]

`CookieSameSite::NO_RESTRICTION`?

+  COOKIE_SAME_SITE_LAX = 1,
+  COOKIE_SAME_SITE_STRICT = 2,
+  COOKIE_SAME_SITE_DEFAULT = COOKIE_SAME_SITE_NONE
+};
+
 // Returns the Set-Cookie header priority token corresponding to |priority|.
 NET_EXPORT const std::string CookiePriorityToString(CookiePriority priority);
 
 // Converts the Set-Cookie header priority token |priority| to a CookiePriority.
 // Defaults to COOKIE_PRIORITY_DEFAULT for empty or unrecognized strings.
 NET_EXPORT CookiePriority StringToCookiePriority(const std::string& priority);
 
+// Returns the Set-Cookie header SameSite token corresponding to |samesite|.
+NET_EXPORT const std::string CookieSameSiteToString(CookieSameSite samesite);

[mmenke, 2016/03/11 18:08:30]

This const seems weird (As does the one in CookiePriorityToString).  Doesn't
seem to get us anything.

[mmenke, 2016/03/11 18:08:30]

same_site is what we use everywhere else (x4, for this file and the CC file)

[Mike West, 2016/03/14 10:18:54]

Removed.
Changed.

+
+// Converst the Set-Cookie header SameSite token |samesite| to a CookieSameSite.
+// Defaults to COOKIE_SAME_SITE_DEFAULT for empty or unrecognized strings.
+NET_EXPORT CookieSameSite StringToCookieSameSite(const std::string& samesite);
+
 }  // namespace net
 
 #endif  // NET_COOKIES_COOKIE_CONSTANTS_H_