Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: ios/net/cookies/system_cookie_util_unittest.mm

Issue 1773133002: SameSite: Implement 'Strict'/'Lax' attribute parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mmenke@ Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/net/cookies/system_cookie_util.mm ('k') | net/cookies/canonical_cookie.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/net/cookies/system_cookie_util.h" 5 #include "ios/net/cookies/system_cookie_util.h"
6 6
7 #import <Foundation/Foundation.h> 7 #import <Foundation/Foundation.h>
8 8
9 #include "base/mac/scoped_nsobject.h" 9 #include "base/mac/scoped_nsobject.h"
10 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
(...skipping 13 matching lines...) Expand all
24 const char kCookieValue[] = "value"; 24 const char kCookieValue[] = "value";
25 const char kCookieValueInvalidUtf8[] = "\x81r\xe4\xbd\xa0\xe5\xa5\xbd"; 25 const char kCookieValueInvalidUtf8[] = "\x81r\xe4\xbd\xa0\xe5\xa5\xbd";
26 26
27 void CheckSystemCookie(const base::Time& expires, bool secure, bool httponly) { 27 void CheckSystemCookie(const base::Time& expires, bool secure, bool httponly) {
28 // Generate a canonical cookie. 28 // Generate a canonical cookie.
29 net::CanonicalCookie canonical_cookie = net::CanonicalCookie( 29 net::CanonicalCookie canonical_cookie = net::CanonicalCookie(
30 GURL(), kCookieName, kCookieValue, kCookieDomain, kCookiePath, 30 GURL(), kCookieName, kCookieValue, kCookieDomain, kCookiePath,
31 base::Time(), // creation 31 base::Time(), // creation
32 expires, 32 expires,
33 base::Time(), // last_access 33 base::Time(), // last_access
34 secure, httponly, 34 secure, httponly, net::CookieSameSite::DEFAULT_MODE,
35 false, // same_site
36 net::COOKIE_PRIORITY_DEFAULT); 35 net::COOKIE_PRIORITY_DEFAULT);
37 // Convert it to system cookie. 36 // Convert it to system cookie.
38 base::scoped_nsobject<NSHTTPCookie> system_cookie( 37 base::scoped_nsobject<NSHTTPCookie> system_cookie(
39 [SystemCookieFromCanonicalCookie(canonical_cookie) retain]); 38 [SystemCookieFromCanonicalCookie(canonical_cookie) retain]);
40 39
41 // Check the attributes. 40 // Check the attributes.
42 EXPECT_TRUE(system_cookie); 41 EXPECT_TRUE(system_cookie);
43 EXPECT_NSEQ(base::SysUTF8ToNSString(kCookieName), [system_cookie name]); 42 EXPECT_NSEQ(base::SysUTF8ToNSString(kCookieName), [system_cookie name]);
44 EXPECT_NSEQ(base::SysUTF8ToNSString(kCookieValue), [system_cookie value]); 43 EXPECT_NSEQ(base::SysUTF8ToNSString(kCookieValue), [system_cookie value]);
45 EXPECT_NSEQ(base::SysUTF8ToNSString(kCookieDomain), [system_cookie domain]); 44 EXPECT_NSEQ(base::SysUTF8ToNSString(kCookieDomain), [system_cookie domain]);
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 117
119 TEST(CookieUtil, SystemCookieFromBadCanonicalCookie) { 118 TEST(CookieUtil, SystemCookieFromBadCanonicalCookie) {
120 // Generate a bad canonical cookie (value is invalid utf8). 119 // Generate a bad canonical cookie (value is invalid utf8).
121 net::CanonicalCookie bad_canonical_cookie = net::CanonicalCookie( 120 net::CanonicalCookie bad_canonical_cookie = net::CanonicalCookie(
122 GURL(), kCookieName, kCookieValueInvalidUtf8, kCookieDomain, kCookiePath, 121 GURL(), kCookieName, kCookieValueInvalidUtf8, kCookieDomain, kCookiePath,
123 base::Time(), // creation 122 base::Time(), // creation
124 base::Time(), // expires 123 base::Time(), // expires
125 base::Time(), // last_access 124 base::Time(), // last_access
126 false, // secure 125 false, // secure
127 false, // httponly 126 false, // httponly
128 false, // same_site 127 net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);
129 net::COOKIE_PRIORITY_DEFAULT);
130 // Convert it to system cookie. 128 // Convert it to system cookie.
131 base::scoped_nsobject<NSHTTPCookie> system_cookie( 129 base::scoped_nsobject<NSHTTPCookie> system_cookie(
132 [SystemCookieFromCanonicalCookie(bad_canonical_cookie) retain]); 130 [SystemCookieFromCanonicalCookie(bad_canonical_cookie) retain]);
133 EXPECT_TRUE(system_cookie == nil); 131 EXPECT_TRUE(system_cookie == nil);
134 } 132 }
135 133
136 } // namespace net 134 } // namespace net
OLDNEW
« no previous file with comments | « ios/net/cookies/system_cookie_util.mm ('k') | net/cookies/canonical_cookie.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698