OLD | NEW |
---|---|
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include <string> | 5 #include <string> |
6 | 6 |
7 #include "net/cookies/cookie_constants.h" | 7 #include "net/cookies/cookie_constants.h" |
8 #include "net/cookies/parsed_cookie.h" | 8 #include "net/cookies/parsed_cookie.h" |
9 #include "testing/gtest/include/gtest/gtest.h" | 9 #include "testing/gtest/include/gtest/gtest.h" |
10 | 10 |
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
85 EXPECT_TRUE(pc.IsValid()); | 85 EXPECT_TRUE(pc.IsValid()); |
86 EXPECT_TRUE(pc.IsSecure()); | 86 EXPECT_TRUE(pc.IsSecure()); |
87 EXPECT_TRUE(pc.HasPath()); | 87 EXPECT_TRUE(pc.HasPath()); |
88 EXPECT_EQ("/", pc.Path()); | 88 EXPECT_EQ("/", pc.Path()); |
89 EXPECT_EQ("", pc.Name()); | 89 EXPECT_EQ("", pc.Name()); |
90 EXPECT_EQ("BLAHHH", pc.Value()); | 90 EXPECT_EQ("BLAHHH", pc.Value()); |
91 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); | 91 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
92 } | 92 } |
93 | 93 |
94 TEST(ParsedCookieTest, TestAttributeCase) { | 94 TEST(ParsedCookieTest, TestAttributeCase) { |
95 ParsedCookie pc("BLAHHH; Path=/; sECuRe; httpONLY; sAmESitE; pRIoRitY=hIgH"); | 95 ParsedCookie pc( |
96 "BLAHHH; Path=/; sECuRe; httpONLY; sAmESitE=StrIct; pRIoRitY=hIgH"); | |
96 EXPECT_TRUE(pc.IsValid()); | 97 EXPECT_TRUE(pc.IsValid()); |
97 EXPECT_TRUE(pc.IsSecure()); | 98 EXPECT_TRUE(pc.IsSecure()); |
98 EXPECT_TRUE(pc.IsHttpOnly()); | 99 EXPECT_TRUE(pc.IsHttpOnly()); |
99 EXPECT_TRUE(pc.IsSameSite()); | 100 EXPECT_EQ(CookieSameSite::STRICT_MODE, pc.SameSite()); |
100 EXPECT_TRUE(pc.HasPath()); | 101 EXPECT_TRUE(pc.HasPath()); |
101 EXPECT_EQ("/", pc.Path()); | 102 EXPECT_EQ("/", pc.Path()); |
102 EXPECT_EQ("", pc.Name()); | 103 EXPECT_EQ("", pc.Name()); |
103 EXPECT_EQ("BLAHHH", pc.Value()); | 104 EXPECT_EQ("BLAHHH", pc.Value()); |
104 EXPECT_EQ(COOKIE_PRIORITY_HIGH, pc.Priority()); | 105 EXPECT_EQ(COOKIE_PRIORITY_HIGH, pc.Priority()); |
105 EXPECT_EQ(5U, pc.NumberOfAttributes()); | 106 EXPECT_EQ(5U, pc.NumberOfAttributes()); |
106 } | 107 } |
107 | 108 |
108 TEST(ParsedCookieTest, TestDoubleQuotedNameless) { | 109 TEST(ParsedCookieTest, TestDoubleQuotedNameless) { |
109 ParsedCookie pc("\"BLA\\\"HHH\"; path=/; secure;"); | 110 ParsedCookie pc("\"BLA\\\"HHH\"; path=/; secure;"); |
(...skipping 30 matching lines...) Expand all Loading... | |
140 EXPECT_TRUE(pc.IsValid()); | 141 EXPECT_TRUE(pc.IsValid()); |
141 EXPECT_EQ("ABC", pc.Name()); | 142 EXPECT_EQ("ABC", pc.Name()); |
142 EXPECT_EQ("", pc.Value()); | 143 EXPECT_EQ("", pc.Value()); |
143 EXPECT_TRUE(pc.HasPath()); | 144 EXPECT_TRUE(pc.HasPath()); |
144 EXPECT_EQ("/wee", pc.Path()); | 145 EXPECT_EQ("/wee", pc.Path()); |
145 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); | 146 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
146 EXPECT_EQ(1U, pc.NumberOfAttributes()); | 147 EXPECT_EQ(1U, pc.NumberOfAttributes()); |
147 } | 148 } |
148 | 149 |
149 TEST(ParsedCookieTest, Whitespace) { | 150 TEST(ParsedCookieTest, Whitespace) { |
150 ParsedCookie pc(" A = BC ;secure;;; samesite "); | 151 ParsedCookie pc(" A = BC ;secure;;; samesite = lax "); |
151 EXPECT_TRUE(pc.IsValid()); | 152 EXPECT_TRUE(pc.IsValid()); |
152 EXPECT_EQ("A", pc.Name()); | 153 EXPECT_EQ("A", pc.Name()); |
153 EXPECT_EQ("BC", pc.Value()); | 154 EXPECT_EQ("BC", pc.Value()); |
154 EXPECT_FALSE(pc.HasPath()); | 155 EXPECT_FALSE(pc.HasPath()); |
155 EXPECT_FALSE(pc.HasDomain()); | 156 EXPECT_FALSE(pc.HasDomain()); |
156 EXPECT_TRUE(pc.IsSecure()); | 157 EXPECT_TRUE(pc.IsSecure()); |
157 EXPECT_FALSE(pc.IsHttpOnly()); | 158 EXPECT_FALSE(pc.IsHttpOnly()); |
158 EXPECT_TRUE(pc.IsSameSite()); | 159 EXPECT_EQ(CookieSameSite::LAX_MODE, pc.SameSite()); |
159 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); | 160 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
160 // We parse anything between ; as attributes, so we end up with two | 161 // We parse anything between ; as attributes, so we end up with two |
161 // attributes with an empty string name and value. | 162 // attributes with an empty string name and value. |
162 EXPECT_EQ(4U, pc.NumberOfAttributes()); | 163 EXPECT_EQ(4U, pc.NumberOfAttributes()); |
163 } | 164 } |
164 TEST(ParsedCookieTest, MultipleEquals) { | 165 TEST(ParsedCookieTest, MultipleEquals) { |
165 ParsedCookie pc(" A=== BC ;secure;;; httponly"); | 166 ParsedCookie pc(" A=== BC ;secure;;; httponly"); |
166 EXPECT_TRUE(pc.IsValid()); | 167 EXPECT_TRUE(pc.IsValid()); |
167 EXPECT_EQ("A", pc.Name()); | 168 EXPECT_EQ("A", pc.Name()); |
168 EXPECT_EQ("== BC", pc.Value()); | 169 EXPECT_EQ("== BC", pc.Value()); |
169 EXPECT_FALSE(pc.HasPath()); | 170 EXPECT_FALSE(pc.HasPath()); |
170 EXPECT_FALSE(pc.HasDomain()); | 171 EXPECT_FALSE(pc.HasDomain()); |
171 EXPECT_TRUE(pc.IsSecure()); | 172 EXPECT_TRUE(pc.IsSecure()); |
172 EXPECT_TRUE(pc.IsHttpOnly()); | 173 EXPECT_TRUE(pc.IsHttpOnly()); |
173 EXPECT_FALSE(pc.IsSameSite()); | |
174 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); | 174 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
mmenke
2016/03/14 20:14:50
optional: Should we keep the SameSite::DEFAULT_MO
| |
175 EXPECT_EQ(4U, pc.NumberOfAttributes()); | 175 EXPECT_EQ(4U, pc.NumberOfAttributes()); |
176 } | 176 } |
177 | 177 |
178 TEST(ParsedCookieTest, QuotedTrailingWhitespace) { | 178 TEST(ParsedCookieTest, QuotedTrailingWhitespace) { |
179 ParsedCookie pc( | 179 ParsedCookie pc( |
180 "ANCUUID=\"zohNumRKgI0oxyhSsV3Z7D\" ; " | 180 "ANCUUID=\"zohNumRKgI0oxyhSsV3Z7D\" ; " |
181 "expires=Sun, 18-Apr-2027 21:06:29 GMT ; " | 181 "expires=Sun, 18-Apr-2027 21:06:29 GMT ; " |
182 "path=/ ; "); | 182 "path=/ ; "); |
183 EXPECT_TRUE(pc.IsValid()); | 183 EXPECT_TRUE(pc.IsValid()); |
184 EXPECT_EQ("ANCUUID", pc.Name()); | 184 EXPECT_EQ("ANCUUID", pc.Name()); |
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
349 EXPECT_TRUE(pc.IsValid()); | 349 EXPECT_TRUE(pc.IsValid()); |
350 | 350 |
351 // Set all other attributes and check that they are appended in order. | 351 // Set all other attributes and check that they are appended in order. |
352 EXPECT_TRUE(pc.SetDomain("domain.com")); | 352 EXPECT_TRUE(pc.SetDomain("domain.com")); |
353 EXPECT_TRUE(pc.SetPath("/")); | 353 EXPECT_TRUE(pc.SetPath("/")); |
354 EXPECT_TRUE(pc.SetExpires("Sun, 18-Apr-2027 21:06:29 GMT")); | 354 EXPECT_TRUE(pc.SetExpires("Sun, 18-Apr-2027 21:06:29 GMT")); |
355 EXPECT_TRUE(pc.SetMaxAge("12345")); | 355 EXPECT_TRUE(pc.SetMaxAge("12345")); |
356 EXPECT_TRUE(pc.SetIsSecure(true)); | 356 EXPECT_TRUE(pc.SetIsSecure(true)); |
357 EXPECT_TRUE(pc.SetIsHttpOnly(true)); | 357 EXPECT_TRUE(pc.SetIsHttpOnly(true)); |
358 EXPECT_TRUE(pc.SetIsHttpOnly(true)); | 358 EXPECT_TRUE(pc.SetIsHttpOnly(true)); |
359 EXPECT_TRUE(pc.SetIsSameSite(true)); | 359 EXPECT_TRUE(pc.SetSameSite("LAX")); |
360 EXPECT_TRUE(pc.SetPriority("HIGH")); | 360 EXPECT_TRUE(pc.SetPriority("HIGH")); |
361 EXPECT_EQ( | 361 EXPECT_EQ( |
362 "name=value; domain=domain.com; path=/; " | 362 "name=value; domain=domain.com; path=/; " |
363 "expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " | 363 "expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " |
364 "httponly; samesite; priority=HIGH", | 364 "httponly; samesite=LAX; priority=HIGH", |
365 pc.ToCookieLine()); | 365 pc.ToCookieLine()); |
366 EXPECT_TRUE(pc.HasDomain()); | 366 EXPECT_TRUE(pc.HasDomain()); |
367 EXPECT_TRUE(pc.HasPath()); | 367 EXPECT_TRUE(pc.HasPath()); |
368 EXPECT_TRUE(pc.HasExpires()); | 368 EXPECT_TRUE(pc.HasExpires()); |
369 EXPECT_TRUE(pc.HasMaxAge()); | 369 EXPECT_TRUE(pc.HasMaxAge()); |
370 EXPECT_TRUE(pc.IsSecure()); | 370 EXPECT_TRUE(pc.IsSecure()); |
371 EXPECT_TRUE(pc.IsHttpOnly()); | 371 EXPECT_TRUE(pc.IsHttpOnly()); |
372 EXPECT_TRUE(pc.IsSameSite()); | 372 EXPECT_EQ(CookieSameSite::LAX_MODE, pc.SameSite()); |
373 EXPECT_EQ(COOKIE_PRIORITY_HIGH, pc.Priority()); | 373 EXPECT_EQ(COOKIE_PRIORITY_HIGH, pc.Priority()); |
374 | 374 |
375 // Clear one attribute from the middle. | 375 // Clear one attribute from the middle. |
376 EXPECT_TRUE(pc.SetPath("/foo")); | 376 EXPECT_TRUE(pc.SetPath("/foo")); |
377 EXPECT_TRUE(pc.HasDomain()); | 377 EXPECT_TRUE(pc.HasDomain()); |
378 EXPECT_TRUE(pc.HasPath()); | 378 EXPECT_TRUE(pc.HasPath()); |
379 EXPECT_TRUE(pc.HasExpires()); | 379 EXPECT_TRUE(pc.HasExpires()); |
380 EXPECT_TRUE(pc.IsSecure()); | 380 EXPECT_TRUE(pc.IsSecure()); |
381 EXPECT_TRUE(pc.IsHttpOnly()); | 381 EXPECT_TRUE(pc.IsHttpOnly()); |
382 EXPECT_EQ( | 382 EXPECT_EQ( |
383 "name=value; domain=domain.com; path=/foo; " | 383 "name=value; domain=domain.com; path=/foo; " |
384 "expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " | 384 "expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " |
385 "httponly; samesite; priority=HIGH", | 385 "httponly; samesite=LAX; priority=HIGH", |
386 pc.ToCookieLine()); | 386 pc.ToCookieLine()); |
387 | 387 |
388 // Set priority to medium. | 388 // Set priority to medium. |
389 EXPECT_TRUE(pc.SetPriority("medium")); | 389 EXPECT_TRUE(pc.SetPriority("medium")); |
390 EXPECT_EQ( | 390 EXPECT_EQ( |
391 "name=value; domain=domain.com; path=/foo; " | 391 "name=value; domain=domain.com; path=/foo; " |
392 "expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " | 392 "expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " |
393 "httponly; samesite; priority=medium", | 393 "httponly; samesite=LAX; priority=medium", |
394 pc.ToCookieLine()); | 394 pc.ToCookieLine()); |
395 | 395 |
396 // Clear the rest and change the name and value. | 396 // Clear the rest and change the name and value. |
397 EXPECT_TRUE(pc.SetDomain(std::string())); | 397 EXPECT_TRUE(pc.SetDomain(std::string())); |
398 EXPECT_TRUE(pc.SetPath(std::string())); | 398 EXPECT_TRUE(pc.SetPath(std::string())); |
399 EXPECT_TRUE(pc.SetExpires(std::string())); | 399 EXPECT_TRUE(pc.SetExpires(std::string())); |
400 EXPECT_TRUE(pc.SetMaxAge(std::string())); | 400 EXPECT_TRUE(pc.SetMaxAge(std::string())); |
401 EXPECT_TRUE(pc.SetIsSecure(false)); | 401 EXPECT_TRUE(pc.SetIsSecure(false)); |
402 EXPECT_TRUE(pc.SetIsHttpOnly(false)); | 402 EXPECT_TRUE(pc.SetIsHttpOnly(false)); |
403 EXPECT_TRUE(pc.SetIsSameSite(false)); | 403 EXPECT_TRUE(pc.SetSameSite(std::string())); |
404 EXPECT_TRUE(pc.SetName("name2")); | 404 EXPECT_TRUE(pc.SetName("name2")); |
405 EXPECT_TRUE(pc.SetValue("value2")); | 405 EXPECT_TRUE(pc.SetValue("value2")); |
406 EXPECT_TRUE(pc.SetPriority(std::string())); | 406 EXPECT_TRUE(pc.SetPriority(std::string())); |
407 EXPECT_FALSE(pc.HasDomain()); | 407 EXPECT_FALSE(pc.HasDomain()); |
408 EXPECT_FALSE(pc.HasPath()); | 408 EXPECT_FALSE(pc.HasPath()); |
409 EXPECT_FALSE(pc.HasExpires()); | 409 EXPECT_FALSE(pc.HasExpires()); |
410 EXPECT_FALSE(pc.HasMaxAge()); | 410 EXPECT_FALSE(pc.HasMaxAge()); |
411 EXPECT_FALSE(pc.IsSecure()); | 411 EXPECT_FALSE(pc.IsSecure()); |
412 EXPECT_FALSE(pc.IsHttpOnly()); | 412 EXPECT_FALSE(pc.IsHttpOnly()); |
413 EXPECT_FALSE(pc.IsSameSite()); | 413 EXPECT_EQ(CookieSameSite::NO_RESTRICTION, pc.SameSite()); |
414 EXPECT_EQ("name2=value2", pc.ToCookieLine()); | 414 EXPECT_EQ("name2=value2", pc.ToCookieLine()); |
415 } | 415 } |
416 | 416 |
417 TEST(ParsedCookieTest, SetPriority) { | 417 TEST(ParsedCookieTest, SetPriority) { |
418 ParsedCookie pc("name=value"); | 418 ParsedCookie pc("name=value"); |
419 EXPECT_TRUE(pc.IsValid()); | 419 EXPECT_TRUE(pc.IsValid()); |
420 | 420 |
421 EXPECT_EQ("name=value", pc.ToCookieLine()); | 421 EXPECT_EQ("name=value", pc.ToCookieLine()); |
422 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); | 422 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
423 | 423 |
(...skipping 17 matching lines...) Expand all Loading... | |
441 | 441 |
442 EXPECT_TRUE(pc.SetPriority("lowerest")); | 442 EXPECT_TRUE(pc.SetPriority("lowerest")); |
443 EXPECT_EQ("name=value; priority=lowerest", pc.ToCookieLine()); | 443 EXPECT_EQ("name=value; priority=lowerest", pc.ToCookieLine()); |
444 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); | 444 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
445 | 445 |
446 EXPECT_TRUE(pc.SetPriority("")); | 446 EXPECT_TRUE(pc.SetPriority("")); |
447 EXPECT_EQ("name=value", pc.ToCookieLine()); | 447 EXPECT_EQ("name=value", pc.ToCookieLine()); |
448 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); | 448 EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
449 } | 449 } |
450 | 450 |
451 TEST(ParsedCookieTest, SetSameSite) { | |
452 ParsedCookie pc("name=value"); | |
453 EXPECT_TRUE(pc.IsValid()); | |
454 | |
455 EXPECT_EQ("name=value", pc.ToCookieLine()); | |
456 EXPECT_EQ(CookieSameSite::DEFAULT_MODE, pc.SameSite()); | |
457 | |
458 // Test each priority, expect case-insensitive compare. | |
459 EXPECT_TRUE(pc.SetSameSite("strict")); | |
460 EXPECT_EQ("name=value; samesite=strict", pc.ToCookieLine()); | |
461 EXPECT_EQ(CookieSameSite::STRICT_MODE, pc.SameSite()); | |
462 | |
463 EXPECT_TRUE(pc.SetSameSite("lAx")); | |
464 EXPECT_EQ("name=value; samesite=lAx", pc.ToCookieLine()); | |
465 EXPECT_EQ(CookieSameSite::LAX_MODE, pc.SameSite()); | |
466 | |
467 EXPECT_TRUE(pc.SetSameSite("LAX")); | |
468 EXPECT_EQ("name=value; samesite=LAX", pc.ToCookieLine()); | |
469 EXPECT_EQ(CookieSameSite::LAX_MODE, pc.SameSite()); | |
470 | |
471 // Interpret invalid priority values as CookieSameSite::DEFAULT_MODE. | |
472 EXPECT_TRUE(pc.SetSameSite("Blah")); | |
473 EXPECT_EQ("name=value; samesite=Blah", pc.ToCookieLine()); | |
474 EXPECT_EQ(CookieSameSite::DEFAULT_MODE, pc.SameSite()); | |
475 | |
476 EXPECT_TRUE(pc.SetSameSite("lowerest")); | |
477 EXPECT_EQ("name=value; samesite=lowerest", pc.ToCookieLine()); | |
478 EXPECT_EQ(CookieSameSite::DEFAULT_MODE, pc.SameSite()); | |
479 | |
480 EXPECT_TRUE(pc.SetSameSite("")); | |
481 EXPECT_EQ("name=value", pc.ToCookieLine()); | |
482 EXPECT_EQ(CookieSameSite::DEFAULT_MODE, pc.SameSite()); | |
483 } | |
484 | |
451 TEST(ParsedCookieTest, InvalidNonAlphanumericChars) { | 485 TEST(ParsedCookieTest, InvalidNonAlphanumericChars) { |
452 ParsedCookie pc1("name=\x05"); | 486 ParsedCookie pc1("name=\x05"); |
453 ParsedCookie pc2( | 487 ParsedCookie pc2( |
454 "name=foo" | 488 "name=foo" |
455 "\x1c" | 489 "\x1c" |
456 "bar"); | 490 "bar"); |
457 ParsedCookie pc3( | 491 ParsedCookie pc3( |
458 "name=foobar" | 492 "name=foobar" |
459 "\x11"); | 493 "\x11"); |
460 ParsedCookie pc4( | 494 ParsedCookie pc4( |
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
543 EXPECT_TRUE(pc5.IsValid()); | 577 EXPECT_TRUE(pc5.IsValid()); |
544 EXPECT_EQ(pc5_literal, pc5.ToCookieLine()); | 578 EXPECT_EQ(pc5_literal, pc5.ToCookieLine()); |
545 EXPECT_TRUE(pc6.IsValid()); | 579 EXPECT_TRUE(pc6.IsValid()); |
546 EXPECT_EQ(pc6_literal, pc6.ToCookieLine()); | 580 EXPECT_EQ(pc6_literal, pc6.ToCookieLine()); |
547 EXPECT_TRUE(pc7.IsValid()); | 581 EXPECT_TRUE(pc7.IsValid()); |
548 EXPECT_EQ(pc7_literal, pc7.ToCookieLine()); | 582 EXPECT_EQ(pc7_literal, pc7.ToCookieLine()); |
549 EXPECT_TRUE(pc8.IsValid()); | 583 EXPECT_TRUE(pc8.IsValid()); |
550 EXPECT_EQ(pc8_literal, pc8.ToCookieLine()); | 584 EXPECT_EQ(pc8_literal, pc8.ToCookieLine()); |
551 } | 585 } |
552 } | 586 } |
OLD | NEW |