Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 177313005: Remove duplicates in runtime macros. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove duplicates in runtime macros. Each item in INLINE_RUNTIME_FUNCTION_LIST had to have a duplicate entry in RUNTIME_FUNCTION_LIST in order to match the comment. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M src/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.h View 10 chunks +4 lines, -15 lines 0 comments Download
M src/runtime.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 9 months ago (2014-02-27 10:22:19 UTC) #1
Sven Panne
LGTM, I stumbled over this several times in the past, but was always too lazy ...
6 years, 9 months ago (2014-02-27 10:45:50 UTC) #2
Yang
6 years, 9 months ago (2014-03-07 08:49:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698