Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1773123003: Fix javadoc warnings in cronet's UploadDataProviders.java (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix javadoc warnings in cronet's UploadDataProviders.java BUG=593074 Committed: https://crrev.com/fce3e9aac221b10ef4a9f3f7aefa5d7a0d79abf2 Cr-Commit-Position: refs/heads/master@{#379979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java View 3 chunks +16 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 8 (3 generated)
agrieve
Came across this when trying to build things locally. Not sure why it's not showing ...
4 years, 9 months ago (2016-03-08 18:19:52 UTC) #2
mef
lgtm
4 years, 9 months ago (2016-03-08 20:51:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773123003/1
4 years, 9 months ago (2016-03-08 23:09:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 23:54:58 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 23:57:43 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fce3e9aac221b10ef4a9f3f7aefa5d7a0d79abf2
Cr-Commit-Position: refs/heads/master@{#379979}

Powered by Google App Engine
This is Rietveld 408576698