Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1773113002: Fixed a few places that incorrectly assumed that profile was initialized (Closed)

Created:
4 years, 9 months ago by Andrew T Wilson (Slow)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed a few places that incorrectly assumed that profile was initialized While testing a fix for crbug.com/532317, I found a few places in the code that assumed that logged-in users would always have an associated profile. However, it can take arbitrarily long from the time that a user logs in until their profile finishes initialization, so code should not make this assumption. This CL fixes the extension garbage collector and ProfileHelper to properly handle uninitialized profiles. BUG=592993 Committed: https://crrev.com/f17bcd66f045d27078a29fc0ace0fa993cec3274 Cr-Commit-Position: refs/heads/master@{#383960}

Patch Set 1 #

Patch Set 2 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/extensions/extension_garbage_collector_chromeos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Andrew T Wilson (Slow)
skuhne: PTAL at profile_manager.cc finnur: PTAL at extensions/*
4 years, 9 months ago (2016-03-08 16:32:07 UTC) #3
Finnur
extensions LGTM
4 years, 9 months ago (2016-03-09 13:49:30 UTC) #4
Mr4D (OOO till 08-26)
lgtm
4 years, 9 months ago (2016-03-23 21:46:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773113002/20001
4 years, 8 months ago (2016-03-30 12:20:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 13:08:21 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 13:09:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f17bcd66f045d27078a29fc0ace0fa993cec3274
Cr-Commit-Position: refs/heads/master@{#383960}

Powered by Google App Engine
This is Rietveld 408576698