Split off CPDF_Parser and CPDF_SimpleParser into .h/.cpp files

core/include/fpdfapi/cpdf_simple_parser.h

Index: core/include/fpdfapi/cpdf_simple_parser.h
diff --git a/core/include/fpdfapi/cpdf_simple_parser.h b/core/include/fpdfapi/cpdf_simple_parser.h
new file mode 100644
index 0000000000000000000000000000000000000000..dc1441d18eb2e3c5b22886c92890ac47ed0507e0
--- /dev/null
+++ b/core/include/fpdfapi/cpdf_simple_parser.h
@@ -0,0 +1,35 @@
+// Copyright 2016 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
+
+#ifndef CORE_INCLUDE_FPDFAPI_CPDF_SIMPLE_PARSER_H_
+#define CORE_INCLUDE_FPDFAPI_CPDF_SIMPLE_PARSER_H_
+
+#include "core/include/fxcrt/fx_string.h"
+#include "core/include/fxcrt/fx_system.h"
+
+class CPDF_SimpleParser {
+ public:
+  CPDF_SimpleParser(const uint8_t* pData, FX_DWORD dwSize);
+  CPDF_SimpleParser(const CFX_ByteStringC& str);
+
+  CFX_ByteStringC GetWord();
+
+  // Find the token and its |nParams| parameters from the start of data,
+  // and move the current position to the start of those parameters.
+  bool FindTagParamFromStart(const CFX_ByteStringC& token, int nParams);
+
+  // For testing only.
+  FX_DWORD GetCurPos() const { return m_dwCurPos; }

[dsinclair, 2016/03/09 15:24:57]

As an aside, what about renaming these to ForTesting, so GetCurPosForTesting()
which makes it obvious from the calling side it's test only.

Not for this CL, but add a tracking bug?

[Tom Sepez, 2016/03/09 18:39:29]

Acknowledged.

+
+ private:
+  void ParseWord(const uint8_t*& pStart, FX_DWORD& dwSize);

[dsinclair, 2016/03/09 15:24:57]

uint8_t*& ? A reference to a pointer?

[Tom Sepez, 2016/03/09 18:39:29]

Yeah, should be a **, I believe the idea is to update the pStart position in the
string as a result of the parse.

+
+  const uint8_t* m_pData;
+  FX_DWORD m_dwSize;
+  FX_DWORD m_dwCurPos;
+};
+
+#endif  // CORE_INCLUDE_FPDFAPI_CPDF_SIMPLE_PARSER_H_