Replace memory.long_running_idle_gmail with TBM based version.

tools/perf/benchmarks/memory.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from core import perf_benchmark
 
 from measurements import memory
 import page_sets
 from telemetry import benchmark
 
+from telemetry.timeline import tracing_category_filter
+from telemetry.web_perf import timeline_based_measurement
+from telemetry.web_perf.metrics import v8_gc_latency
+from telemetry.web_perf.metrics import memory_timeline
 
 @benchmark.Disabled('all')  # crbug.com/581147
 class MemoryMobile(perf_benchmark.PerfBenchmark):
   test = memory.Memory
   page_set = page_sets.MobileMemoryPageSet
 
   @classmethod
   def Name(cls):
     return 'memory.mobile_memory'
 
@@ skipping 10 matching lines @@
 
   @classmethod
   def Name(cls):
     return 'memory.top_7_stress'
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     return cls.IsSvelte(possible_browser)  # http://crbug.com/555092
 
 
-class MemoryLongRunningIdleGmail(perf_benchmark.PerfBenchmark):
+# Disabled on reference builds because they don't support the new
+# Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
+@benchmark.Disabled('reference', 'android')  # crbug.com/579546

[perezju, 2016/03/09 15:07:55]

just double checking, why disabling this test on android?

[ulan, 2016/03/09 17:18:39]

The page is too heavy for android, fails with OOM.

+class MemoryLongRunningIdleGmailTBM(perf_benchmark.PerfBenchmark):

[perezju, 2016/03/09 15:07:55]

maybe move benchmark to memory_infra.py and subclass from _MemoryInfra
benchmark? (that also helps to avoid duplicating the workaround in
SetExtraBrowserOptions below)

[ulan, 2016/03/09 17:18:39]

Done.

   """Use (recorded) real world web sites and measure memory consumption
   of long running idle Gmail page """
-  test = memory.Memory
   page_set = page_sets.LongRunningIdleGmailPageSet
 
+  def SetExtraBrowserOptions(self, options):
+    options.AppendExtraBrowserArgs([
+        # TODO(perezju): Temporary workaround to disable periodic memory dumps.
+        # See: http://crbug.com/513692
+        '--enable-memory-benchmarking',
+    ])
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    v8_categories = [
+        'blink.console', 'renderer.scheduler', 'v8', 'webkit.console']
+    memory_categories = 'blink.console,disabled-by-default-memory-infra'
+    category_filter = tracing_category_filter.TracingCategoryFilter(
+        memory_categories)
+    for category in v8_categories:
+      category_filter.AddIncludedCategory(category)
+    options = timeline_based_measurement.Options(category_filter)
+    options.SetLegacyTimelineBasedMetrics([

[perezju, 2016/03/09 15:07:55]

maybe this should be moved to SetupBenchmarkDefaultTraceRerunOptions, so that
running in debug mode still records values for all metrics.

[ulan, 2016/03/09 17:18:39]

I tried that, but the method was not being called at all.

[perezju, 2016/03/10 09:34:36]

Hmm, you're right. SetupTraceRerunOptions is only called for old style PageTest
benchmarks, and not for new TBM ones (c.f. [1]). Please leave a TODO here and
file a bug on me to get this fixed, as this is also broken for other benchmarks
above.

[1]:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu...

[ulan, 2016/03/10 11:09:25]

Done.

+        v8_gc_latency.V8GCLatency(),
+        memory_timeline.MemoryTimelineMetric()])
+    return options
+
   @classmethod
   def Name(cls):
-    return 'memory.long_running_idle_gmail'
+    return 'memory.long_running_idle_gmail_tbm'
 
+  @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return True
 
 @benchmark.Disabled('android')  # crbug.com/542682
 class MemoryLongRunningIdleGmailBackground(perf_benchmark.PerfBenchmark):
   """Use (recorded) real world web sites and measure memory consumption
   of long running idle Gmail page in background tab"""
   test = memory.Memory
   page_set = page_sets.LongRunningIdleGmailBackgroundPageSet
 
   @classmethod
   def Name(cls):
     return 'memory.long_running_idle_gmail_background'