Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1773073002: Revert of [Media Router] Enable autoresizing for the Media Router dialog for Mac. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
Kevin M
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] Enable autoresizing for the Media Router dialog for Mac. (patchset #2 id:40001 of https://codereview.chromium.org/1680533003/ ) Reason for revert: Autoresizing currently breaks Print Preview. This patch needs to be reverted first since it depends on autoresizing. Original issue's description: > [Media Router] Enable autoresizing for the Media Router dialog for Mac. > > This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. > > Screenshots - dynamic sizing! > https://screenshot.googleplex.com/vKTA1A7HXFu.png > https://screenshot.googleplex.com/suVDcHMjuMY.png > https://screenshot.googleplex.com/kZkoCD6n9tu.png > https://screenshot.googleplex.com/iQpxy84e9CB.png > https://screenshot.googleplex.com/7aYGEVB0ggX.png > https://screenshot.googleplex.com/E3XZLwUGBii.png > https://screenshot.googleplex.com/nBNTjvbEmjT.png > https://screenshot.googleplex.com/QSEcTzbicV8.png > > BUG=508544, 580272, 580273 > > Committed: https://crrev.com/f285202a82526e75efe12b52f5b6ab62b9b6bacb > Cr-Commit-Position: refs/heads/master@{#379659} TBR=kmarshall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508544, 580272, 580273 Committed: https://crrev.com/8f50b0af527a4bf5c9317771abb9941bdece4426 Cr-Commit-Position: refs/heads/master@{#379769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc View 3 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
apacible
Created Revert of [Media Router] Enable autoresizing for the Media Router dialog for Mac.
4 years, 9 months ago (2016-03-08 06:55:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773073002/1
4 years, 9 months ago (2016-03-08 06:55:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 06:55:52 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 06:57:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f50b0af527a4bf5c9317771abb9941bdece4426
Cr-Commit-Position: refs/heads/master@{#379769}

Powered by Google App Engine
This is Rietveld 408576698