Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1773053002: PPC: [turbofan] Further fixing ES6 tail call elimination in Turbofan. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Further fixing ES6 tail call elimination in Turbofan. Port 2aae579cf04b24f605d1ae6b975d67d8dbbee672 Original commit message: In case when F tail calls G we should also remove the potential arguments adaptor frame for F. This CL introduces two new machine instructions ArchTailCallCodeObjectFromJSFunction and ArchTailCallJSFunctionFromJSFunction which (unlike existing ArchTailCallCodeObject and ArchTailCallJSFunction) also drop arguments adaptor frame if it exists right before jumping to the target function. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=N Committed: https://crrev.com/fcaa643dab7757225697446dcdccd77417d2d899 Cr-Commit-Position: refs/heads/master@{#34589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 4 chunks +36 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-08 05:37:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773053002/1
4 years, 9 months ago (2016-03-08 05:38:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 05:52:34 UTC) #5
michael_dawson
On 2016/03/08 05:52:34, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-08 12:36:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773053002/1
4 years, 9 months ago (2016-03-08 14:47:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 14:51:51 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 14:53:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcaa643dab7757225697446dcdccd77417d2d899
Cr-Commit-Position: refs/heads/master@{#34589}

Powered by Google App Engine
This is Rietveld 408576698