Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1773043002: Revert of Enable XFA-Forms for the PDFium plugin (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez, rpop
CC:
chromium-reviews, pawliger, Lei Zhang, dsinclair, Oliver Chang, Wei Li, laforge
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable XFA-Forms for the PDFium plugin (patchset #1 id:1 of https://codereview.chromium.org/1761673002/ ) Reason for revert: Fails to build with clang-cl with very very scary warnings: In file included from ..\..\third_party\pdfium\xfa/src/fxfa/src/app/xfa_ffapp.h:15: ..\..\third_party\pdfium\xfa/src/fgas/include/fx_fnt.h(131,23) : error: first operand of this 'memcmp' call is a pointer to dynamic class '_FX_FONTSIGNATURE'; vtable pointer will be compared [-Werror,-Wdynamic-class-memaccess] FXSYS_memcmp(&left.FontSignature, &right.FontSignature, ~~~~~~~~~~~~ ^ ..\..\third_party\pdfium\xfa/src/fgas/include/fx_fnt.h(131,23) : note: explicitly cast the pointer to silence this warning FXSYS_memcmp(&left.FontSignature, &right.FontSignature, ^ (void*) Reverting for now. Original issue's description: > Enable XFA-Forms for the PDFium plugin. > > This is a change to gather stability, performance, and size > data and will be rolled back by 2016-03-15. > > This is the gyp portion of the change; the GN variables > controlling the same things currently reside in the pdfium > product itsef. > > Committed: https://crrev.com/afa43e7fa9754cff9ceb6969c665830a79a84c5b > Cr-Commit-Position: refs/heads/master@{#379622} TBR=rpop@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/bb9cf1d14cf9f859dfc153663a67573132fcd99f Cr-Commit-Position: refs/heads/master@{#379700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M build/common.gypi View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
Created Revert of Enable XFA-Forms for the PDFium plugin
4 years, 9 months ago (2016-03-08 02:13:34 UTC) #1
Nico
see e.g. this bot: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/7473
4 years, 9 months ago (2016-03-08 02:13:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773043002/1
4 years, 9 months ago (2016-03-08 02:14:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 02:15:30 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 02:17:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb9cf1d14cf9f859dfc153663a67573132fcd99f
Cr-Commit-Position: refs/heads/master@{#379700}

Powered by Google App Engine
This is Rietveld 408576698