src/pdf/SkPDFFormXObject.cpp - Issue 1773033002: SkPDF: use sk_make_sp<T> when it makes sense.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFFormXObject.cpp

Issue 1773033002: SkPDF: use sk_make_sp<T> when it makes sense. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: 2016-03-08 (Tuesday) 06:54:33 EST Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFFormXObject.cpp

diff --git a/src/pdf/SkPDFFormXObject.cpp b/src/pdf/SkPDFFormXObject.cpp

index 4647f5a8a12b570b947e9dd683d5772a08c8348a..abf331f5444fc10de8e1c9c8ecccc9b483445a56 100644

--- a/src/pdf/SkPDFFormXObject.cpp

+++ b/src/pdf/SkPDFFormXObject.cpp

@@ -65,7 +65,7 @@ void SkPDFFormXObject::init(const char* colorSpace,

// Right now SkPDFFormXObject is only used for saveLayer, which implies

// isolated blending. Do this conditionally if that changes.

- sk_sp<SkPDFDict> group(new SkPDFDict("Group"));

+ auto group = sk_make_sp<SkPDFDict>("Group");

group->insertName("S", "Transparency");

if (colorSpace != nullptr) {

« no previous file with comments | « src/pdf/SkPDFFont.cpp ('k') | src/pdf/SkPDFGraphicState.cpp » ('j') | no next file with comments »