Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: src/pdf/SkPDFShader.h

Issue 1773033002: SkPDF: use sk_make_sp<T> when it makes sense. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-03-07 (Monday) 20:36:11 EST Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/pdf/SkPDFShader.h
diff --git a/src/pdf/SkPDFShader.h b/src/pdf/SkPDFShader.h
index 3de17cdc509ca104c1e8f7ee949fd84b6f86eed5..dbf0b74b499cb822313aafec12e5e66be05bd042 100644
--- a/src/pdf/SkPDFShader.h
+++ b/src/pdf/SkPDFShader.h
@@ -51,17 +51,15 @@ public:
};
class SkPDFFunctionShader final : public SkPDFDict {
-
-
public:
static SkPDFFunctionShader* Create(SkPDFCanon*,
SkAutoTDelete<SkPDFShader::State>*);
+ SkPDFFunctionShader(SkPDFShader::State*);
bungeman-skia 2016/03/08 02:20:36 eh, I don't think I'd make this public just becaus
bungeman-skia 2016/03/08 03:27:21 I find this interesting and std::shared_pointer ha
hal.canary 2016/03/08 11:58:48 Done.
virtual ~SkPDFFunctionShader();
bool equals(const SkPDFShader::State&) const;
private:
SkAutoTDelete<const SkPDFShader::State> fShaderState;
- SkPDFFunctionShader(SkPDFShader::State*);
typedef SkPDFDict INHERITED;
};

Powered by Google App Engine
This is Rietveld 408576698