Set keymap in prefs when switching modes in Next.

Set keymap in prefs when switching modes in Next.

Previously, we were only setting the ChromeVoxKBHandler member (which was sufficient to get key events to trigger commands). However, the actual pref wasn't being set so ChromeVox's panel didn't pick up on it.

TEST=manual
BUG=592684
Committed: https://crrev.com/936bb9cf6ce9bc8b0f97321197ed8eecb971354d
Cr-Commit-Position: refs/heads/master@{#379940}

[David Tseng, 2016-03-08 00:06:48]

Description was changed from

==========
Set keymap in prefs when switching modes in Next.
==========

to

==========
Set keymap in prefs when switching modes in Next.

Previously, we were only setting the ChromeVoxKBHandler member (which was
sufficient to get key events to trigger commands). However, the actual pref
wasn't being set so ChromeVox's panel didn't pick up on it.

TEST=manual
BUG=592684
==========

[David Tseng, 2016-03-08 00:06:48]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-03-08 21:31:20]

Friendly ping; would like to get this merged.

On Mon, Mar 7, 2016 at 4:06 PM, <dtseng@chromium.org> wrote:

> Reviewers: dmazzoni
> CL: https://codereview.chromium.org/1773003002/
>
> Description:
> Set keymap in prefs when switching modes in Next.
>
> Previously, we were only setting the ChromeVoxKBHandler member (which was
> sufficient to get key events to trigger commands). However, the actual pref
> wasn't being set so ChromeVox's panel didn't pick up on it.
>
> TEST=manual
> BUG=592684
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@fix_warnings
>
> Affected files (+3, -2 lines):
> M chrome/browser/resources/chromeos/chromevox/chromevox/
> background/prefs.js
> M chrome/browser/resources/chromeos/chromevox/cvox2/
> background/background.js
>
>
> Index: chrome/browser/resources/chromeos/chromevox/chromevox/
> background/prefs.js
> diff --git
a/chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js
> b/chrome/browser/resources/chromeos/chromevox/chromevox/
> background/prefs.js
> index a0d64ef86fac0d32b73451ab564b87a178251fc7..
> 709af5751a3c547788ce106451d6b03018e4e10f 100644
> --- a/chrome/browser/resources/chromeos/chromevox/chromevox/
> background/prefs.js
> +++ b/chrome/browser/resources/chromeos/chromevox/chromevox/
> background/prefs.js
> @@ -110,6 +110,7 @@ cvox.ChromeVoxPrefs.prototype.switchToKeyMap =
> function(selectedKeyMap) {
> // class to manage multiple key maps.
> localStorage['currentKeyMap'] = selectedKeyMap;
> this.keyMap_ = cvox.KeyMap.fromCurrentKeyMap();
> + cvox.ChromeVoxKbHandler.handlerKeyMap = this.keyMap_;
> this.keyMap_.toLocalStorage();
> this.keyMap_.resetModifier();
> this.sendPrefsToAllTabs(false, true);
> Index: chrome/browser/resources/chromeos/chromevox/cvox2/
> background/background.js
> diff --git
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
> b/chrome/browser/resources/chromeos/chromevox/cvox2/
> background/background.js
> index bb137d17b87f2aed2630b4545f96c0f22006624f..
> a279da828ab91a13158114599d71a3f0b5ec36dc 100644
> --- a/chrome/browser/resources/chromeos/chromevox/cvox2/
> background/background.js
> +++ b/chrome/browser/resources/chromeos/chromevox/cvox2/
> background/background.js
> @@ -170,9 +170,9 @@ Background.prototype = {
> // cvox.KeySequence.deserialize which gets called by cvox.KeyMap.
> cvox.ChromeVox.sequenceSwitchKeyCodes = [];
> if (mode === ChromeVoxMode.CLASSIC || mode === ChromeVoxMode.COMPAT)
> - cvox.ChromeVoxKbHandler.handlerKeyMap = cvox.KeyMap.fromDefaults();
> + window['prefs'].switchToKeyMap('keymap_classic');
> else
> - cvox.ChromeVoxKbHandler.handlerKeyMap = cvox.KeyMap.fromNext();
> + window['prefs'].switchToKeyMap('keymap_next');
>
> if (mode == ChromeVoxMode.CLASSIC) {
> if (chrome.commands &&
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-03-08 21:35:04]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-03-08 21:35:05]

lgtm

[commit-bot: I haz the power, 2016-03-08 21:35:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773003002/1

[commit-bot: I haz the power, 2016-03-08 22:27:16]

Description was changed from

==========
Set keymap in prefs when switching modes in Next.

Previously, we were only setting the ChromeVoxKBHandler member (which was
sufficient to get key events to trigger commands). However, the actual pref
wasn't being set so ChromeVox's panel didn't pick up on it.

TEST=manual
BUG=592684
==========

to

==========
Set keymap in prefs when switching modes in Next.

Previously, we were only setting the ChromeVoxKBHandler member (which was
sufficient to get key events to trigger commands). However, the actual pref
wasn't being set so ChromeVox's panel didn't pick up on it.

TEST=manual
BUG=592684
==========

[commit-bot: I haz the power, 2016-03-08 22:27:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-08 22:29:33]

Description was changed from

==========
Set keymap in prefs when switching modes in Next.

Previously, we were only setting the ChromeVoxKBHandler member (which was
sufficient to get key events to trigger commands). However, the actual pref
wasn't being set so ChromeVox's panel didn't pick up on it.

TEST=manual
BUG=592684
==========

to

==========
Set keymap in prefs when switching modes in Next.

Previously, we were only setting the ChromeVoxKBHandler member (which was
sufficient to get key events to trigger commands). However, the actual pref
wasn't being set so ChromeVox's panel didn't pick up on it.

TEST=manual
BUG=592684

Committed: https://crrev.com/936bb9cf6ce9bc8b0f97321197ed8eecb971354d
Cr-Commit-Position: refs/heads/master@{#379940}
==========

[commit-bot: I haz the power, 2016-03-08 22:29:34]

Patchset 1 (id:??) landed as
https://crrev.com/936bb9cf6ce9bc8b0f97321197ed8eecb971354d
Cr-Commit-Position: refs/heads/master@{#379940}