Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 1773003002: Set keymap in prefs when switching modes in Next. (Closed)

Created:
4 years, 9 months ago by David Tseng
Modified:
4 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_warnings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set keymap in prefs when switching modes in Next. Previously, we were only setting the ChromeVoxKBHandler member (which was sufficient to get key events to trigger commands). However, the actual pref wasn't being set so ChromeVox's panel didn't pick up on it. TEST=manual BUG=592684 Committed: https://crrev.com/936bb9cf6ce9bc8b0f97321197ed8eecb971354d Cr-Commit-Position: refs/heads/master@{#379940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
David Tseng
4 years, 9 months ago (2016-03-08 00:06:55 UTC) #3
David Tseng
Friendly ping; would like to get this merged. On Mon, Mar 7, 2016 at 4:06 ...
4 years, 9 months ago (2016-03-08 21:31:20 UTC) #4
dmazzoni
lgtm
4 years, 9 months ago (2016-03-08 21:35:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773003002/1
4 years, 9 months ago (2016-03-08 21:35:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 22:27:17 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 22:29:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/936bb9cf6ce9bc8b0f97321197ed8eecb971354d
Cr-Commit-Position: refs/heads/master@{#379940}

Powered by Google App Engine
This is Rietveld 408576698