Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1772973002: Completely de-virtualize CPDF_SyntaxParser. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Completely de-virtualize CPDF_SyntaxParser. It isn't sub-classed. Making GetNextChar() non-virtual may save a virtual fn call per character if the compilers aren't able to do so themselves. Make members private, not protected. BUG= R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9f7b5e1b5e0dfd7310a2eb9e586bc998f8ea11fa

Patch Set 1 #

Patch Set 2 : Unfriend CPDF_SyntaxParser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 4 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Oliver, for review.
4 years, 9 months ago (2016-03-07 22:45:13 UTC) #3
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-07 22:52:29 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-07 22:55:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9f7b5e1b5e0dfd7310a2eb9e586bc998f8ea11fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698