Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1772963002: Reset limit of map_insert_remove_oom_test and skip on noopt/precompilation. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reset limit of map_insert_remove_oom_test and skip on noopt/precompilation. Increasing the heap limit to allow for the compiled core libraries in noopt/precompilation requires increasing the iteration count to make the test meaningful, but this also makes it too slow on simarm64, etc. Cf. baf4d84f34be9fa1138f52ae99ad87d6b35bafdd BUG=http://dartbug.com/24678 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/865b8eedfc2f4e089a22567a6098d9fcd486ce14

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/standalone/map_insert_remove_oom_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-07 22:14:59 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-03-07 22:17:48 UTC) #3
rmacnak
4 years, 9 months ago (2016-03-07 22:23:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
865b8eedfc2f4e089a22567a6098d9fcd486ce14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698