Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1772943003: Add wrappers for the module module (Closed)

Created:
4 years, 9 months ago by dsansome
Modified:
4 years, 9 months ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : CL comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -19 lines) Patch
A filter/count/mod.go View 1 chunk +70 lines, -0 lines 0 comments Download
M filter/featureBreaker/gi.go View 1 chunk +1 line, -1 line 0 comments Download
M filter/featureBreaker/mail.go View 1 chunk +1 line, -1 line 0 comments Download
M filter/featureBreaker/mc.go View 1 chunk +1 line, -1 line 0 comments Download
A filter/featureBreaker/mod.go View 1 chunk +75 lines, -0 lines 0 comments Download
M filter/featureBreaker/rds.go View 2 chunks +2 lines, -2 lines 0 comments Download
M filter/featureBreaker/tq.go View 1 chunk +1 line, -1 line 0 comments Download
M filter/featureBreaker/user.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/dummy/doc.go View 1 chunk +1 line, -0 lines 0 comments Download
M impl/dummy/dummy.go View 3 chunks +22 lines, -0 lines 0 comments Download
M impl/dummy/dummy_test.go View 2 chunks +9 lines, -0 lines 0 comments Download
M impl/memory/context.go View 1 chunk +1 line, -1 line 0 comments Download
A impl/memory/module.go View 1 1 chunk +64 lines, -0 lines 0 comments Download
A impl/memory/module_test.go View 1 1 chunk +34 lines, -0 lines 0 comments Download
M impl/prod/context.go View 2 chunks +2 lines, -1 line 0 comments Download
A impl/prod/module.go View 1 chunk +51 lines, -0 lines 0 comments Download
A + service/module/context.go View 5 chunks +10 lines, -10 lines 0 comments Download
A service/module/interface.go View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dsansome
4 years, 9 months ago (2016-03-08 06:59:12 UTC) #2
iannucci1
lgtm https://codereview.chromium.org/1772943003/diff/1/impl/memory/module.go File impl/memory/module.go (right): https://codereview.chromium.org/1772943003/diff/1/impl/memory/module.go#newcode39 impl/memory/module.go:39: } this should probably change the number of ...
4 years, 9 months ago (2016-03-08 07:44:26 UTC) #4
dsansome
https://codereview.chromium.org/1772943003/diff/1/impl/memory/module.go File impl/memory/module.go (right): https://codereview.chromium.org/1772943003/diff/1/impl/memory/module.go#newcode39 impl/memory/module.go:39: } On 2016/03/08 07:44:26, iannucci1 wrote: > this should ...
4 years, 9 months ago (2016-03-08 10:55:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772943003/20001
4 years, 9 months ago (2016-03-08 10:55:46 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 10:59:03 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/8e00d275fb3b96b050708bb91e2c0bd69c73aa62

Powered by Google App Engine
This is Rietveld 408576698