Issue 177293009: Handle arguments objects in frame when materializing arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177293009: Handle arguments objects in frame when materializing arguments (Closed)

Created:
6 years, 9 months ago by Jarin

Modified:
6 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle arguments objects in frame when materializing arguments R=mstarzinger@chromium.org BUG=347262 Committed: https://code.google.com/p/v8/source/detail?r=19584

Patch Set 1 #

Total comments: 5

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -32 lines)			Patch
M	src/deoptimizer.h	View	3 chunks	+18 lines, -2 lines	0 comments	Download
M	src/deoptimizer.cc	View	7 chunks	+27 lines, -17 lines	4 comments	Download
A +	test/mjsunit/regress/regress-347262.js	View	1 chunk	+31 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/177293009/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/177293009/diff/1/src/deoptimizer.cc#newcode3051 src/deoptimizer.cc:3051: CHECK(false); // We should never get ...

6 years, 9 months ago (2014-02-27 14:37:40 UTC) #2

Jarin

6 years, 9 months ago (2014-02-27 15:12:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19584 (tree was closed).

Expand Messages | Collapse Messages