Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 177293003: Revert of Chromium plumbing for Screen Orientation API orientationchange events. (Closed)

Created:
6 years, 10 months ago by acleung1
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Peter Beverloo, Inactive, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Chromium plumbing for Screen Orientation API orientationchange events. (https://codereview.chromium.org/164913004/) Reason for revert: SEE: https://code.google.com/p/chromium/issues/detail?id=346595 Original issue's description: > Chromium plumbing for Screen Orientation API orientationchange events. > > This is using RenderViewObserver::OrientationChangeEvent and dispatch > the information down to the renderer. More will come with locking > and unlocking abilities. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253029 TBR=jochen@chromium.org,cdn@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -359 lines) Patch
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 6 chunks +1 line, -12 lines 0 comments Download
D content/browser/screen_orientation/screen_orientation_dispatcher_host.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/browser/screen_orientation/screen_orientation_dispatcher_host.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/screen_orientation_messages.h View 1 chunk +0 lines, -21 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +3 lines, -7 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 4 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +0 lines, -13 lines 0 comments Download
D content/renderer/screen_orientation/screen_orientation_dispatcher.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/renderer/screen_orientation/screen_orientation_dispatcher.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
acleung1
Created Revert of Chromium plumbing for Screen Orientation API orientationchange events.
6 years, 10 months ago (2014-02-25 04:01:46 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 04:07:33 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-25 04:07:33 UTC) #3
Dan Beam
lgtm
6 years, 10 months ago (2014-02-25 04:28:40 UTC) #4
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 10 months ago (2014-02-25 04:28:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/177293003/1
6 years, 10 months ago (2014-02-25 04:34:28 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 04:39:51 UTC) #7
Message was sent while issue was closed.
Change committed as 253077

Powered by Google App Engine
This is Rietveld 408576698