Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 177293002: Version 1.2.0-dev.5.15 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 32951)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1817,6 +1817,8 @@
handledBySpecialCase = true;
if (input is HIs) {
emitIs(input, '!==');
+ } else if (input is HNot) {
+ use(input.inputs[0]);
} else if (input is HIdentity) {
HIdentity identity = input;
emitIdentityComparison(identity.left, identity.right, true);
@@ -1866,11 +1868,7 @@
} else if (node.inputs[1].isConstantBoolean()) {
String operation = node.inputs[1].isConstantFalse() ? '&&' : '||';
if (operation == '||') {
- if (input is HNot) {
- use(input.inputs[0]);
- } else {
- generateNot(input);
- }
+ generateNot(input);
} else {
use(input);
}

Powered by Google App Engine
This is Rietveld 408576698