Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1772913003: gae_ts_mon: flush metrics asynchronously (Closed)

Created:
4 years, 9 months ago by Sergey Berezin
Modified:
4 years, 9 months ago
Reviewers:
iannucci, dsansome
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

gae_ts_mon: flush metrics asynchronously Start flushing metrics at the beginning of a request in a parallel thread. This reduces the overall latency of the request. BUG=591122 R=dsansome@chromium.org, iannucci@chromium.org TEST=load-tested in the cloud Committed: https://chromium.googlesource.com/infra/infra/+/5d220c3d397eb320a1e451e6c40df629dae48428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M appengine_module/gae_ts_mon/config.py View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Berezin
PTAL. Evidence that it works: logs from a request that took 1.19 sec: 16:44:26.044 ts_mon: ...
4 years, 9 months ago (2016-03-08 00:55:16 UTC) #1
iannucci
nice :) lgtm
4 years, 9 months ago (2016-03-08 01:09:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772913003/1
4 years, 9 months ago (2016-03-08 01:26:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/5d220c3d397eb320a1e451e6c40df629dae48428
4 years, 9 months ago (2016-03-08 01:30:35 UTC) #6
dsansome
4 years, 9 months ago (2016-03-08 02:37:18 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698