Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1772873004: Re-enable BackgroundTracingManagerBrowserTest.CallTriggersMoreThanOnceOnlyGatherOnce under TSan. (Closed)

Created:
4 years, 9 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable BackgroundTracingManagerBrowserTest.CallTriggersMoreThanOnceOnlyGatherOnce under TSan. AsConvertableToTraceFormat should not be racy anymore after the mega-tracing refactoring of crrev.com/1717283003 BUG=559117 TBR=reillyg@chromium.org,glider@chromium.org Committed: https://crrev.com/6b12fb5c059c5a6b24b0bee9048fc78fa3a7b51b Cr-Commit-Position: refs/heads/master@{#379808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M content/browser/tracing/background_tracing_manager_browsertest.cc View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Primiano Tucci (use gerrit)
4 years, 9 months ago (2016-03-08 11:17:08 UTC) #3
Alexander Potapenko
On 2016/03/08 11:17:08, Primiano wrote: LGTM
4 years, 9 months ago (2016-03-08 11:17:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772873004/1
4 years, 9 months ago (2016-03-08 11:18:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 11:53:16 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 11:54:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b12fb5c059c5a6b24b0bee9048fc78fa3a7b51b
Cr-Commit-Position: refs/heads/master@{#379808}

Powered by Google App Engine
This is Rietveld 408576698