Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1772863002: Add advance[XY]Fixed getters for Android. (Closed)

Created:
4 years, 9 months ago by dogben
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add advance[XY]Fixed getters for Android. This prepares for changing the type of these fields to float. BUG=skia:4632 Committed: https://skia.googlesource.com/skia/+/19de504eaee0c18cac4f840e0ca336a1e41b65eb

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/core/SkGlyph.h View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772863002/1
4 years, 9 months ago (2016-03-07 19:45:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 20:09:37 UTC) #5
dogben
4 years, 9 months ago (2016-03-07 20:29:59 UTC) #7
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-07 20:40:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772863002/1
4 years, 9 months ago (2016-03-07 20:40:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/19de504eaee0c18cac4f840e0ca336a1e41b65eb
4 years, 9 months ago (2016-03-07 20:41:51 UTC) #13
bungeman-skia
4 years, 9 months ago (2016-03-07 23:02:55 UTC) #14
Message was sent while issue was closed.
Another thing...

https://codereview.chromium.org/1772863002/diff/1/src/core/SkGlyph.h
File src/core/SkGlyph.h (right):

https://codereview.chromium.org/1772863002/diff/1/src/core/SkGlyph.h#newcode96
src/core/SkGlyph.h:96: 
I know this has already landed, but the post-review in my head tells me we also
put a #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK around this, so that nobody else
tries to get at it.

Powered by Google App Engine
This is Rietveld 408576698