third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp - Issue 1772853002: Block the HTML parser on external stylesheets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

Issue 1772853002: Block the HTML parser on external stylesheets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplified parser blocking logic Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

index 8fb44c1e27e7ce81b2d7c54dc08428a4f2d3d195..578b257bddfffdc6d3c5832a0dac141ea5743d97 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

@@ -152,6 +152,8 @@ HTMLTreeBuilderSimulator::SimulatedToken HTMLTreeBuilderSimulator::simulate(cons

} else if (threadSafeMatch(tagName, scriptTag)) {

tokenizer->setState(HTMLTokenizer::ScriptDataState);

simulatedToken = ScriptStart;

+ } else if (threadSafeMatch(tagName, linkTag)) {

+ simulatedToken = LinkToken;

} else if (threadSafeMatch(tagName, styleTag)

|| threadSafeMatch(tagName, iframeTag)

|| threadSafeMatch(tagName, xmpTag)

@@ -175,6 +177,9 @@ HTMLTreeBuilderSimulator::SimulatedToken HTMLTreeBuilderSimulator::simulate(cons

tokenizer->setState(HTMLTokenizer::DataState);

return ScriptEnd;

}

+ if (threadSafeMatch(tagName, styleTag)) {

+ simulatedToken = StyleEnd;

+ }

}

// FIXME: Also setForceNullCharacterReplacement when in text mode.