Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1772843003: [wasm] Some cleanup in the Int64Lowering. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Some cleanup in the Int64Lowering. I removed some stale comments and added a missing unit test. R=titzer@chromium.org Committed: https://crrev.com/7634d1aac172a73bf650e5f54f654bb32ccf0d38 Cr-Commit-Position: refs/heads/master@{#34586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M src/compiler/int64-lowering.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 4 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 9 months ago (2016-03-08 13:51:38 UTC) #1
titzer
lgtm
4 years, 9 months ago (2016-03-08 13:58:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772843003/1
4 years, 9 months ago (2016-03-08 14:07:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 14:11:55 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 14:12:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7634d1aac172a73bf650e5f54f654bb32ccf0d38
Cr-Commit-Position: refs/heads/master@{#34586}

Powered by Google App Engine
This is Rietveld 408576698