Remove SystemHealthMetric (fka RAILScore)

Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span, system_health_side_panel, weather_report*.

Clearing it out of the way will make it easier to Metric-ify Responsiveness and
Efficiency, and replace the side panel with a grouping table for metrics.

BUG=catapult:#2105

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c75918b2b2d2f4b95a5e90b5e379c4214628ac6e

[benjhayden, 2016-03-07 18:52:15]

Description was changed from

==========
Remove SystemHealthMetric (fka RAILScore)

BUG=catapult:#2105
==========

to

==========
Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span and system_health_side_panel.



BUG=catapult:#2105
==========

[benjhayden, 2016-03-07 18:52:15]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org, nduca@chromium.org

[benjhayden, 2016-03-07 18:54:52]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-03-07 18:54:57]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2016-03-07 18:55:36]

Description was changed from

==========
Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span and system_health_side_panel.



BUG=catapult:#2105
==========

to

==========
Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span, system_health_side_panel, weather_report*.



BUG=catapult:#2105
==========

[benjhayden, 2016-03-07 18:56:38]

Description was changed from

==========
Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span, system_health_side_panel, weather_report*.



BUG=catapult:#2105
==========

to

==========
Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span, system_health_side_panel, weather_report*.

Clearing it out of the way will make it easier to Metric-ify Responsiveness and
Efficiency, and replace the side panel with a grouping table for metrics.

BUG=catapult:#2105
==========

[benjhayden, 2016-03-07 19:00:20]

Importing all_metrics.html from somewhere is required in order to keep the
remaining metrics in trace_viewer.gypi.
Should I setup all_metrics.html differently, or remove the metrics from
trace_viewer.gypi for now?

Also, I'm not sure exactly what should be done in perf_insights for this CL.

[nduca, 2016-03-07 19:10:01]

lets hook up timeline_view.html for now. its kinda a dirty hack but i think it
avoids some lurking surprises around how configs work we don't wanna deal with
now (like making map_traces aware of config objects)

https://codereview.chromium.org/1772833002/diff/40001/tracing/tracing/ui/extr...
File tracing/tracing/ui/extras/chrome_config.html (left):

https://codereview.chromium.org/1772833002/diff/40001/tracing/tracing/ui/extr...
tracing/tracing/ui/extras/chrome_config.html:22: <!-- Lots of chrome-specific
extras -->
not loving the removal of the comments, can you leave them? if you wanna switch
to fully alphabetized imports thats another cl

[nduca, 2016-03-07 19:10:23]

lets leave it to ethan and oysteine to advice how to deal with the pi
depenedencies. i'm fine deleting stuff personally.

[benjhayden, 2016-03-07 19:21:19]

Sorry, can you clarify "hook up timeline_view.html"? Should I import
all_metrics.html from that file instead of chrome_config.html?

Also see question about alphabetized imports.

https://codereview.chromium.org/1772833002/diff/40001/tracing/tracing/ui/extr...
File tracing/tracing/ui/extras/chrome_config.html (left):

https://codereview.chromium.org/1772833002/diff/40001/tracing/tracing/ui/extr...
tracing/tracing/ui/extras/chrome_config.html:22: <!-- Lots of chrome-specific
extras -->
On 2016/03/07 at 19:10:01, nduca wrote:
> not loving the removal of the comments, can you leave them? if you wanna
switch to fully alphabetized imports thats another cl

I was just following the instructions of the presubmit linter.
I used --bypass-hooks to upload Patch 2 with the comments restored.
Should I file a bug about the presubmit linter requiring alphabetized imports?

[nduca, 2016-03-07 19:24:03]

On 2016/03/07 at 19:21:19, benjhayden wrote:
> Sorry, can you clarify "hook up timeline_view.html"? Should I import
all_metrics.html from that file instead of chrome_config.html?
Yeah.

> 
> Also see question about alphabetized imports.
> 
>
https://codereview.chromium.org/1772833002/diff/40001/tracing/tracing/ui/extr...
> File tracing/tracing/ui/extras/chrome_config.html (left):
> 
>
https://codereview.chromium.org/1772833002/diff/40001/tracing/tracing/ui/extr...
> tracing/tracing/ui/extras/chrome_config.html:22: <!-- Lots of chrome-specific
extras -->
> On 2016/03/07 at 19:10:01, nduca wrote:
> > not loving the removal of the comments, can you leave them? if you wanna
switch to fully alphabetized imports thats another cl
> 
> I was just following the instructions of the presubmit linter.
> I used --bypass-hooks to upload Patch 2 with the comments restored.
> Should I file a bug about the presubmit linter requiring alphabetized imports?

Didn't know linter required that. Just do that change in a different patch I
guess.

[eakuefner-google (do not use), 2016-03-07 20:43:13]

On 2016/03/07 at 19:10:23, nduca wrote:
> lets leave it to ethan and oysteine to advice how to deal with the pi
depenedencies. i'm fine deleting stuff personally.

Killing the weather report stuff should be fine; just please remove the
offending reports as well. I'll just land a CL before you finish this one to
eliminate the slice cost report's dependency on wr.

[eakuefner, 2016-03-07 20:52:42]

On 2016/03/07 at 20:43:13, eakuefner wrote:
> On 2016/03/07 at 19:10:23, nduca wrote:
> > lets leave it to ethan and oysteine to advice how to deal with the pi
depenedencies. i'm fine deleting stuff personally.
> 
> Killing the weather report stuff should be fine; just please remove the
offending reports as well. I'll just land a CL before you finish this one to
eliminate the slice cost report's dependency on wr.

Actually, I'm not going to do that; just go ahead and kill this stuff. The slice
cost computation is not being modified by this CL anyway (in
perf_insights/mappers/slice_cost.html, which is just full of helpers), so if we
want to keep it, it can be reimplemented as a metric later, after Ben has worked
out the new side panel with grouping table.

[benjhayden, 2016-03-07 22:17:06]

PTAL?

[nduca, 2016-03-07 22:22:04]

lgtm on my part, hopefully ethan can do a grown up readthrough

[eakuefner, 2016-03-07 22:30:16]

lgtm

[benjhayden, 2016-03-08 00:21:46]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-03-08 00:21:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/1772833002/#ps100001
(title: "remove task info report")

[commit-bot: I haz the power, 2016-03-08 00:21:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772833002/100001

[commit-bot: I haz the power, 2016-03-08 00:24:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:24:28]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[benjhayden, 2016-03-08 00:51:58]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:52:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772833002/100001

[commit-bot: I haz the power, 2016-03-08 00:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:54:00]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[benjhayden, 2016-03-08 18:59:18]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2016-03-08 18:59:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772833002/100001

[commit-bot: I haz the power, 2016-03-08 19:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 19:29:46]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[benjhayden, 2016-03-08 20:45:15]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-03-08 20:45:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/1772833002/#ps120001
(title: "fix pi test")

[commit-bot: I haz the power, 2016-03-08 20:45:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772833002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772833002/120001

[commit-bot: I haz the power, 2016-03-08 21:06:57]

Description was changed from

==========
Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span, system_health_side_panel, weather_report*.

Clearing it out of the way will make it easier to Metric-ify Responsiveness and
Efficiency, and replace the side panel with a grouping table for metrics.

BUG=catapult:#2105
==========

to

==========
Remove SystemHealthMetric (fka RAILScore)

This metric is no longer necessary, and neither are its UI:
system_health_span, system_health_side_panel, weather_report*.

Clearing it out of the way will make it easier to Metric-ify Responsiveness and
Efficiency, and replace the side panel with a grouping table for metrics.

BUG=catapult:#2105

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-03-08 21:06:58]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...