Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1772823003: Rename Vector::prepend to Vector::prependVector (Closed)

Created:
4 years, 9 months ago by yhirano
Modified:
4 years, 9 months ago
Reviewers:
hiroshige, Nico
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Vector::prepend to Vector::prependVector template <typename U> prepend(U&&) shadows template <typnemae U, size_t c, typename V> prepend(const Vector<U, c, v>&) in some cases, so this CL renames the latter. This is also aligned with append and appendVector. BUG=592086 Committed: https://crrev.com/c80deb3ba2db12ded8d637e467aed8366922913a Cr-Commit-Position: refs/heads/master@{#380063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/wtf/Vector.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
yhirano
4 years, 9 months ago (2016-03-07 18:59:40 UTC) #2
sof
(https://isocpp.org/blog/2012/11/universal-references-in-c11-scott-meyers might be helpful in understanding why.)
4 years, 9 months ago (2016-03-07 19:04:50 UTC) #3
Nico
If this doesn't have any callers, can't we just delete this?
4 years, 9 months ago (2016-03-08 02:27:58 UTC) #5
yhirano
On 2016/03/08 02:27:58, Nico wrote: > If this doesn't have any callers, can't we just ...
4 years, 9 months ago (2016-03-08 02:29:25 UTC) #6
Nico
ok, lgtm
4 years, 9 months ago (2016-03-08 02:36:19 UTC) #7
Nico
(i think it's a bit weird to have a built-in prepend method on vector, given ...
4 years, 9 months ago (2016-03-08 02:37:27 UTC) #8
hiroshige
non-owner lgtm.
4 years, 9 months ago (2016-03-09 00:39:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772823003/1
4 years, 9 months ago (2016-03-09 00:40:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 04:22:40 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 04:41:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c80deb3ba2db12ded8d637e467aed8366922913a
Cr-Commit-Position: refs/heads/master@{#380063}

Powered by Google App Engine
This is Rietveld 408576698