Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1772813002: [Media Router] Fixed window refocus problem for filter view input. (Closed)

Created:
4 years, 9 months ago by btolsch
Modified:
4 years, 9 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Fixed window refocus problem for filter view input. This change fixes the following case: 1. The user enters filter view. 2. The user presses the Escape key which leaves filter view but keeps keyboard focus on the search input. 3. The user focuses another window and then returns to the media router dialog. 4. The dialog automatically switches to filter view. The dialog should not be triggered to switch to filter view only by changing window focus. BUG=592723 R=apacible@chromium.org Committed: https://crrev.com/87227cdfcad72f70bc803deded83e5f638199de0 Cr-Commit-Position: refs/heads/master@{#380182}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -3 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 3 chunks +49 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
btolsch
This fixes the window re-focus bug. Unfortunately I couldn't find a much simpler way to ...
4 years, 9 months ago (2016-03-07 20:22:25 UTC) #2
apacible
lgtm https://codereview.chromium.org/1772813002/diff/1/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js File chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js (right): https://codereview.chromium.org/1772813002/diff/1/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js#newcode198 chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:198: * @type {boolean} nit: @private {boolean} https://codereview.chromium.org/1772813002/diff/1/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js#newcode470 chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:470: ...
4 years, 9 months ago (2016-03-09 18:43:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772813002/20001
4 years, 9 months ago (2016-03-09 18:58:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 20:03:00 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 20:04:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87227cdfcad72f70bc803deded83e5f638199de0
Cr-Commit-Position: refs/heads/master@{#380182}

Powered by Google App Engine
This is Rietveld 408576698