Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1772803003: [turbofan] Thread through object boilerplate length. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest, rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Thread through object boilerplate length. This adds the number of properties to be expected within the boilerplate object for object literals to the TurboFan IR. The reason is that this length can no longer be easily inferred from just the constants array. The length is potentially non-zero for empty object literals and might also diverge in the presence of constant functions or duplicate property names. For future safety and for symmetry reasons, the same change was applied to array literals as well, even though inferring the length from the constant elements is still possible there. R=verwaest@chromium.org BUG=chromium:593008 LOG=n Committed: https://crrev.com/f7934b64273f6489f4b91642faaa482d73a46caf Cr-Commit-Position: refs/heads/master@{#34594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/js-operator.cc View 5 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
Toon: PTAL. Ross: FYI.
4 years, 9 months ago (2016-03-08 15:58:32 UTC) #2
Toon Verwaest
thanks, lgtm
4 years, 9 months ago (2016-03-08 16:57:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772803003/1
4 years, 9 months ago (2016-03-08 17:00:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 17:02:31 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 17:04:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7934b64273f6489f4b91642faaa482d73a46caf
Cr-Commit-Position: refs/heads/master@{#34594}

Powered by Google App Engine
This is Rietveld 408576698