Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1772803002: Avoid redundant weak pointer updates after evacuation. (Closed)

Created:
4 years, 9 months ago by ulan
Modified:
4 years, 9 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid redundant weak pointer updates after evacuation. Since we record slots for weak list fields, there is no need to iterate over them after evacuation. We just need to update the roots for which we didn't record slots. This speeds up the evacuate_update_pointers_weak phase by ~2.5x. BUG= Committed: https://crrev.com/4db396b172e2e87d95d211934d9baef528cd3043 Cr-Commit-Position: refs/heads/master@{#34555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
ulan
ptal
4 years, 9 months ago (2016-03-07 17:47:33 UTC) #3
Michael Lippautz
lgtm
4 years, 9 months ago (2016-03-07 17:59:45 UTC) #4
Michael Lippautz
lgtm
4 years, 9 months ago (2016-03-07 17:59:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772803002/1
4 years, 9 months ago (2016-03-07 18:19:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 18:44:20 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 18:45:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4db396b172e2e87d95d211934d9baef528cd3043
Cr-Commit-Position: refs/heads/master@{#34555}

Powered by Google App Engine
This is Rietveld 408576698