Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1772763002: Replace base::Tuple in //ppapi with std::tuple (Closed)

Created:
4 years, 9 months ago by tzik
Modified:
4 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace base::Tuple in //ppapi with std::tuple BUG=554987 Committed: https://crrev.com/a0f614d7cfeafaf2a33e3845ffae86e7ed5a6769 Cr-Commit-Position: refs/heads/master@{#379688}

Patch Set 1 #

Patch Set 2 : update #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -53 lines) Patch
M ppapi/host/dispatch_host_message.h View 2 chunks +17 lines, -15 lines 0 comments Download
M ppapi/proxy/dispatch_reply_message.h View 2 chunks +16 lines, -14 lines 0 comments Download
M ppapi/proxy/nacl_message_scanner.cc View 2 chunks +15 lines, -14 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/resource_message_test_sink.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M ppapi/proxy/websocket_resource_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772763002/1
4 years, 9 months ago (2016-03-07 16:50:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772763002/20001
4 years, 9 months ago (2016-03-07 16:59:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 17:47:24 UTC) #6
tzik
PTAL
4 years, 9 months ago (2016-03-07 18:53:32 UTC) #8
raymes
lgtm
4 years, 9 months ago (2016-03-07 23:02:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772763002/20001
4 years, 9 months ago (2016-03-08 00:28:12 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 00:35:26 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 00:36:26 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a0f614d7cfeafaf2a33e3845ffae86e7ed5a6769
Cr-Commit-Position: refs/heads/master@{#379688}

Powered by Google App Engine
This is Rietveld 408576698