Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 177263003: Only swap positions if both characters actually are absolute positioned (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Only swap positions if both characters actually are absolute positioned When re-ordering inline boxes within a "line", character-based absolute positioning attributes are re-ordered to match. However, when attempting to re-order/swap a inline box that does have a absolute positioning attribute (and is of length 1) with one that doesn't, the positioning attribute is copied rather than swapped - leading to additional chunks being created and consequently additional adjustments being performed. However, swapping is not needed/required in this case, since the attribute is already in the correct (logical) position. To mitigate this, only perform the attribute swap if both characters (and consequently inline boxes) have attributes in the first place. BUG=343486 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
A LayoutTests/svg/text/bidi-dir-rtl.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/bidi-dir-rtl-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +4 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
6 years, 10 months ago (2014-02-24 16:13:26 UTC) #1
Stephen Chennney
The test doesn't seem to be passing. I'm not sure if that's some artifact of ...
6 years, 10 months ago (2014-02-24 16:42:54 UTC) #2
fs
On 2014/02/24 16:42:54, Stephen Chenney wrote: > The test doesn't seem to be passing. I'm ...
6 years, 10 months ago (2014-02-24 17:10:51 UTC) #3
Stephen Chennney
lgtm
6 years, 10 months ago (2014-02-24 19:18:09 UTC) #4
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-25 09:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/177263003/1
6 years, 10 months ago (2014-02-25 09:24:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/177263003/1
6 years, 10 months ago (2014-02-25 13:28:56 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 15:04:49 UTC) #8
Message was sent while issue was closed.
Change committed as 167777

Powered by Google App Engine
This is Rietveld 408576698