Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: content/common/ssl_status_serialization_unittest.cc

Issue 1772603002: Addition of Certificate Transparency details to Security panel of DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed SignedCertificateTimestampStore and SignedCertificateTimestampIDStatus(List) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/ssl_status_serialization_unittest.cc
diff --git a/content/common/ssl_status_serialization_unittest.cc b/content/common/ssl_status_serialization_unittest.cc
index d479518add63ab52a74e694f2eff5b17b7434d8f..f802a3c0916b47d068010666fc84ad8fea578d6f 100644
--- a/content/common/ssl_status_serialization_unittest.cc
+++ b/content/common/ssl_status_serialization_unittest.cc
@@ -18,8 +18,9 @@ void SetTestStatus(SSLStatus* status) {
status->security_bits = 80;
status->key_exchange_info = 23;
status->connection_status = net::SSL_CONNECTION_VERSION_TLS1_2;
- status->signed_certificate_timestamp_ids.push_back(
- SignedCertificateTimestampIDAndStatus(1, net::ct::SCT_STATUS_OK));
+ status->num_unknown_scts = 0;
+ status->num_invalid_scts = 0;
+ status->num_valid_scts = 3;
}
bool SSLStatusAreEqual(const SSLStatus& a, const SSLStatus &b) {
@@ -36,7 +37,9 @@ std::ostream& operator<<(std::ostream& os, const SSLStatus& status) {
<< "\nKey exchange info: " << status.key_exchange_info
<< "\nConnection status: " << status.connection_status
<< "\nContent Status: " << status.content_status
- << "\nNumber of SCTs: " << status.signed_certificate_timestamp_ids.size();
+ << "\nNumber of unknown SCTs: " << status.num_unknown_scts
+ << "\nNumber of invalid SCTs: " << status.num_invalid_scts
+ << "\nNumber of valid SCTs: " << status.num_valid_scts;
}
// Test that a valid serialized SSLStatus returns true on
@@ -50,8 +53,6 @@ TEST(SSLStatusSerializationTest, DeserializeSerializedStatus) {
SSLStatus deserialized;
ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized));
EXPECT_PRED2(SSLStatusAreEqual, status, deserialized);
- EXPECT_EQ(SignedCertificateTimestampIDAndStatus(1, net::ct::SCT_STATUS_OK),
- deserialized.signed_certificate_timestamp_ids[0]);
// Test that |content_status| has the default (initialized) value.
EXPECT_EQ(SSLStatus::NORMAL_CONTENT, deserialized.content_status);
}

Powered by Google App Engine
This is Rietveld 408576698