Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

Issue 1772603002: Addition of Certificate Transparency details to Security panel of DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reacted to comments of dgozman Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
index cdae907291d6bb119e1b0b633e00c974b1f116fd..5e216403ffe4ebb48c910480c62943ad5cb7db42 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
@@ -405,11 +405,27 @@ static std::unique_ptr<protocol::Network::Response> buildObjectForResourceRespon
.setNumInvalidScts(numInvalidSCTs)
.setNumValidScts(numValidSCTs).build();
+ // Add all SCT(s) to an array.
dgozman 2016/06/09 08:34:12 nit: this comment doesn't add anything.
dwaxweiler 2016/06/10 07:42:37 Acknowledged.
+ std::unique_ptr<protocol::Array<protocol::Network::SignedCertificateTimestamp>> signedCertificateTimestampList = protocol::Array<protocol::Network::SignedCertificateTimestamp>::create();
+ for (auto const& sct : responseSecurityDetails->sctList) {
+ std::unique_ptr<protocol::Network::SignedCertificateTimestamp> signedCertificateTimestamp = protocol::Network::SignedCertificateTimestamp::create()
+ .setStatus(sct.m_status)
+ .setOrigin(sct.m_origin)
+ .setLogDescription(sct.m_logDescription)
+ .setLogId(sct.m_logId)
+ .setTimestamp(sct.m_timestamp)
+ .setHashAlgorithm(sct.m_hashAlgorithm)
+ .setSignatureAlgorithm(sct.m_signatureAlgorithm)
+ .setSignatureData(sct.m_signatureData).build();
+ signedCertificateTimestampList->addItem(std::move(signedCertificateTimestamp));
+ }
+
std::unique_ptr<protocol::Network::SecurityDetails> securityDetails = protocol::Network::SecurityDetails::create()
.setProtocol(responseSecurityDetails->protocol)
.setKeyExchange(responseSecurityDetails->keyExchange)
.setCipher(responseSecurityDetails->cipher)
- .setCertificateId(responseSecurityDetails->certID).build();
+ .setCertificateId(responseSecurityDetails->certID)
+ .setSignedCertificateTimestampList(std::move(signedCertificateTimestampList)).build();
securityDetails->setCertificateValidationDetails(std::move(certificateValidationDetails));
if (responseSecurityDetails->mac.length() > 0)
securityDetails->setMac(responseSecurityDetails->mac);

Powered by Google App Engine
This is Rietveld 408576698