third_party/WebKit/Source/platform/exported/WebURLResponse.cpp - Issue 1772603002: Addition of Certificate Transparency details to Security panel of DevTools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

Issue 1772603002: Addition of Certificate Transparency details to Security panel of DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed version, renamed Blink variables, simplified some comments, handled a few MAX values Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('K') | « third_party/WebKit/Source/devtools/protocol.json ('k') | third_party/WebKit/Source/platform/network/ResourceResponse.h » ('j') | third_party/WebKit/Source/platform/network/ResourceResponse.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

index 1766df4cfbb2ab2ed61983fab6b127f41abec122..1a7178e53e2f28170907dcb53aba62abc312cf9c 100644

--- a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

@@ -323,6 +323,9 @@ void WebURLResponse::setSecurityStyle(SecurityStyle securityStyle)

void WebURLResponse::setSecurityDetails(const WebSecurityDetails& webSecurityDetails)

{

+ blink::ResourceResponse::SignedCertificateTimestampList sctList;

+ for (auto const& iter : webSecurityDetails.sctList)

+ sctList.push_back(static_cast<blink::ResourceResponse::SignedCertificateTimestamp>(iter));

m_private->m_resourceResponse->setSecurityDetails(

webSecurityDetails.protocol,

webSecurityDetails.keyExchange,

@@ -331,7 +334,8 @@ void WebURLResponse::setSecurityDetails(const WebSecurityDetails& webSecurityDet

webSecurityDetails.certId,

webSecurityDetails.numUnknownScts,

webSecurityDetails.numInvalidScts,

- webSecurityDetails.numValidScts);

+ webSecurityDetails.numValidScts,

+ sctList);

}

ResourceResponse& WebURLResponse::toMutableResourceResponse()