Addition of Certificate Transparency details to Security panel of DevTools

third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
index 7a9344d93be54ed04baf9ab2ccaed23b03ae6187..05dc8ed6de9fbefb04e8cdc3272777cd81fb4aab 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
@@ -413,11 +413,28 @@ static PassOwnPtr<protocol::Network::Response> buildObjectForResourceResponse(co
             .setNumInvalidScts(numInvalidSCTs)
             .setNumValidScts(numValidSCTs).build();
 
+        // Add all SCT(s) to an array.
+        OwnPtr<protocol::Array<protocol::Network::SignedCertificateTimestamp>> signedCertificateTimestampList = protocol::Array<protocol::Network::SignedCertificateTimestamp>::create();

[palmer, 2016/05/23 19:54:25]

A typedef might help make this more readable.

[Eran Messeri, 2016/05/25 12:42:21]

You should rebase - OwnPtr seems to be gone in favour of std::unique_ptr, here
and in line 419.

[dwaxweiler, 2016/05/27 23:13:00]

@Eran: Acknowledged.
@palmer: Where should I place such a typedef?

+        for (auto const& sct : responseSecurityDetails->sctList) {
+            OwnPtr<protocol::Network::SignedCertificateTimestamp> signedCertificateTimestamp = protocol::Network::SignedCertificateTimestamp::create()
+                .setStatus(sct.status)
+                .setOrigin(sct.origin)
+                .setVersion(sct.version)
+                .setLogDescription(sct.logDescription)
+                .setLogId(sct.logId)
+                .setTimestamp(sct.timestamp)
+                .setHashAlgorithm(sct.hashAlgorithm)
+                .setSignatureAlgorithm(sct.signatureAlgorithm)
+                .setSignatureData(sct.signatureData).build();
+            signedCertificateTimestampList->addItem(signedCertificateTimestamp.release());

[Eran Messeri, 2016/05/25 12:42:21]

Since you should be using unique_ptrs, this would now be:
signedCertificateTimestampList->addItem(std::move(signedCertificateTimestamp));

[dwaxweiler, 2016/05/27 23:13:00]

Acknowledged.

+        }
+
         OwnPtr<protocol::Network::SecurityDetails> securityDetails = protocol::Network::SecurityDetails::create()
             .setProtocol(responseSecurityDetails->protocol)
             .setKeyExchange(responseSecurityDetails->keyExchange)
             .setCipher(responseSecurityDetails->cipher)
-            .setCertificateId(responseSecurityDetails->certID).build();
+            .setCertificateId(responseSecurityDetails->certID)
+            .setSignedCertificateTimestampList(std::move(signedCertificateTimestampList)).build();
         securityDetails->setCertificateValidationDetails(std::move(certificateValidationDetails));
         if (responseSecurityDetails->mac.length() > 0)
             securityDetails->setMac(responseSecurityDetails->mac);