Addition of Certificate Transparency details to Security panel of DevTools

third_party/WebKit/Source/platform/network/ResourceResponse.cpp

 /*
  * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "platform/network/ResourceResponse.h"
 
 #include "wtf/CurrentTime.h"
 #include "wtf/StdLibExtras.h"
 
 namespace blink {
 
+ResourceResponse::SignedCertificateTimestamp::SignedCertificateTimestamp(
+    const blink::WebURLResponse::SignedCertificateTimestamp& sct)
+    : status(sct.status)
+    , origin(sct.origin)
+    , version(sct.version)

[palmer, 2016/05/23 19:54:25]

I think you might want to adhere to the m_fooBar convention in Blink.

[dwaxweiler, 2016/05/27 23:13:00]

Acknowledged.

+    , logDescription(sct.logDescription)
+    , logId(sct.logId)
+    , timestamp(sct.timestamp)
+    , hashAlgorithm(sct.hashAlgorithm)
+    , signatureAlgorithm(sct.signatureAlgorithm)
+    , signatureData(sct.signatureData)
+{
+}
+
 ResourceResponse::ResourceResponse()
     : m_expectedContentLength(0)
     , m_httpStatusCode(0)
     , m_lastModifiedDate(0)
     , m_wasCached(false)
     , m_connectionID(0)
     , m_connectionReused(false)
     , m_isNull(true)
     , m_haveParsedAgeHeader(false)
     , m_haveParsedDateHeader(false)
@@ skipping 74 matching lines @@
     m_hasMajorCertificateErrors = data->m_hasMajorCertificateErrors;
     m_securityStyle = data->m_securityStyle;
     m_securityDetails.protocol = data->m_securityDetails.protocol;
     m_securityDetails.cipher = data->m_securityDetails.cipher;
     m_securityDetails.keyExchange = data->m_securityDetails.keyExchange;
     m_securityDetails.mac = data->m_securityDetails.mac;
     m_securityDetails.certID = data->m_securityDetails.certID;
     m_securityDetails.numUnknownSCTs = data->m_securityDetails.numUnknownSCTs;
     m_securityDetails.numInvalidSCTs = data->m_securityDetails.numInvalidSCTs;
     m_securityDetails.numValidSCTs = data->m_securityDetails.numValidSCTs;
+    m_securityDetails.sctList = data->m_securityDetails.sctList;
     m_httpVersion = data->m_httpVersion;
     m_appCacheID = data->m_appCacheID;
     m_appCacheManifestURL = data->m_appCacheManifestURL.copy();
     m_multipartBoundary = data->m_multipartBoundary;
     m_wasFetchedViaSPDY = data->m_wasFetchedViaSPDY;
     m_wasNpnNegotiated = data->m_wasNpnNegotiated;
     m_wasAlternateProtocolAvailable = data->m_wasAlternateProtocolAvailable;
     m_wasFetchedViaProxy = data->m_wasFetchedViaProxy;
     m_wasFetchedViaServiceWorker = data->m_wasFetchedViaServiceWorker;
     m_wasFallbackRequiredByServiceWorker = data->m_wasFallbackRequiredByServiceWorker;
@@ skipping 28 matching lines @@
     data->m_hasMajorCertificateErrors = m_hasMajorCertificateErrors;
     data->m_securityStyle = m_securityStyle;
     data->m_securityDetails.protocol = m_securityDetails.protocol.isolatedCopy();
     data->m_securityDetails.cipher = m_securityDetails.cipher.isolatedCopy();
     data->m_securityDetails.keyExchange = m_securityDetails.keyExchange.isolatedCopy();
     data->m_securityDetails.mac = m_securityDetails.mac.isolatedCopy();
     data->m_securityDetails.certID = m_securityDetails.certID;
     data->m_securityDetails.numUnknownSCTs = m_securityDetails.numUnknownSCTs;
     data->m_securityDetails.numInvalidSCTs = m_securityDetails.numInvalidSCTs;
     data->m_securityDetails.numValidSCTs = m_securityDetails.numValidSCTs;
+    data->m_securityDetails.sctList = m_securityDetails.sctList;
     data->m_httpVersion = m_httpVersion;
     data->m_appCacheID = m_appCacheID;
     data->m_appCacheManifestURL = m_appCacheManifestURL.copy();
     data->m_multipartBoundary = m_multipartBoundary;
     data->m_wasFetchedViaSPDY = m_wasFetchedViaSPDY;
     data->m_wasNpnNegotiated = m_wasNpnNegotiated;
     data->m_wasAlternateProtocolAvailable = m_wasAlternateProtocolAvailable;
     data->m_wasFetchedViaProxy = m_wasFetchedViaProxy;
     data->m_wasFetchedViaServiceWorker = m_wasFetchedViaServiceWorker;
     data->m_wasFallbackRequiredByServiceWorker = m_wasFallbackRequiredByServiceWorker;
@@ skipping 131 matching lines @@
     else if (equalIgnoringCase(name, cacheControlHeaderString()) || equalIgnoringCase(name, pragmaHeaderString()))
         m_cacheControlHeader = CacheControlHeader();
     else if (equalIgnoringCase(name, dateHeader))
         m_haveParsedDateHeader = false;
     else if (equalIgnoringCase(name, expiresHeader))
         m_haveParsedExpiresHeader = false;
     else if (equalIgnoringCase(name, lastModifiedHeader))
         m_haveParsedLastModifiedHeader = false;
 }
 
-void ResourceResponse::setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId, size_t numUnknownScts, size_t numInvalidScts, size_t numValidScts)
+void ResourceResponse::setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId, size_t numUnknownScts, size_t numInvalidScts, size_t numValidScts, const SignedCertificateTimestampList& sctList)
 {
     m_securityDetails.protocol = protocol;
     m_securityDetails.keyExchange = keyExchange;
     m_securityDetails.cipher = cipher;
     m_securityDetails.mac = mac;
     m_securityDetails.certID = certId;
     m_securityDetails.numUnknownSCTs = numUnknownScts;
     m_securityDetails.numInvalidSCTs = numInvalidScts;
     m_securityDetails.numValidSCTs = numValidScts;
+    m_securityDetails.sctList = sctList;
 }
 
 void ResourceResponse::setHTTPHeaderField(const AtomicString& name, const AtomicString& value)
 {
     updateHeaderParsedState(name);
 
     m_httpHeaderFields.set(name, value);
 }
 
 void ResourceResponse::addHTTPHeaderField(const AtomicString& name, const AtomicString& value)
@@ skipping 222 matching lines @@
     if (a.httpHeaderFields() != b.httpHeaderFields())
         return false;
     if (a.resourceLoadTiming() && b.resourceLoadTiming() && *a.resourceLoadTiming() == *b.resourceLoadTiming())
         return true;
     if (a.resourceLoadTiming() != b.resourceLoadTiming())
         return false;
     return true;
 }
 
 } // namespace blink