Addition of Certificate Transparency details to Security panel of DevTools

content/public/common/ssl_status.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_SSL_STATUS_H_
 #define CONTENT_PUBLIC_COMMON_SSL_STATUS_H_
 
 #include "content/common/content_export.h"
 #include "content/public/common/security_style.h"
-#include "content/public/common/signed_certificate_timestamp_id_and_status.h"
 #include "net/cert/cert_status_flags.h"
 
 namespace net {
 class SSLInfo;
 }
 
 namespace content {
 
 // Collects the SSL information for this NavigationEntry.
 struct CONTENT_EXPORT SSLStatus {
   // Flags used for the page security content status.
   enum ContentStatusFlags {
     // HTTP page, or HTTPS page with no insecure content.
     NORMAL_CONTENT             = 0,
 
     // HTTPS page containing "displayed" HTTP resources (e.g. images, CSS).
     DISPLAYED_INSECURE_CONTENT = 1 << 0,
 
     // HTTPS page containing "executed" HTTP resources (i.e. script).
     // Also currently used for HTTPS page containing broken-HTTPS resources;
     // this is wrong and should be fixed (see comments in
     // SSLPolicy::OnRequestStarted()).
     RAN_INSECURE_CONTENT       = 1 << 1,
   };
 
   SSLStatus();
   SSLStatus(SecurityStyle security_style,
             int cert_id,
-            const SignedCertificateTimestampIDStatusList&
-                signed_certificate_timestamp_ids,
             const net::SSLInfo& ssl_info);
   SSLStatus(const SSLStatus& other);
   ~SSLStatus();
 
   bool Equals(const SSLStatus& status) const {
     return security_style == status.security_style &&
            cert_id == status.cert_id && cert_status == status.cert_status &&
            security_bits == status.security_bits &&
            key_exchange_info == status.key_exchange_info &&
            connection_status == status.connection_status &&
            content_status == status.content_status &&
-           signed_certificate_timestamp_ids ==
-               status.signed_certificate_timestamp_ids;
+           num_unknown_scts == status.num_unknown_scts &&
+           num_invalid_scts == status.num_invalid_scts &&
+           num_valid_scts == status.num_valid_scts;
   }
 
   content::SecurityStyle security_style;
   // A cert_id value of 0 indicates that it is unset or invalid.
   int cert_id;
   net::CertStatus cert_status;
   int security_bits;
   int key_exchange_info;
   int connection_status;
   // A combination of the ContentStatusFlags above.
   int content_status;
-  SignedCertificateTimestampIDStatusList signed_certificate_timestamp_ids;
+  // Signed Certificate Timestamps (SCTs) of Certificat Transparency (CT).

[palmer, 2016/04/26 23:12:01]

Typo: "Certificate"

[dwaxweiler, 2016/04/28 07:46:20]

Acknowledged.

+  int num_unknown_scts;

[palmer, 2016/04/26 23:12:01]

In content/child/web_url_loader_impl.cc you used size_t for these. It's probably
best to be consistent, either way, unless there is some reason I don't know
about.

[dwaxweiler, 2016/04/28 07:46:20]

Acknowledged.

+  int num_invalid_scts;
+  int num_valid_scts;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_SSL_STATUS_H_