[sql] Callback and scoped-ignore tests for sql::Statement.

sql/connection.cc

Index: sql/connection.cc
diff --git a/sql/connection.cc b/sql/connection.cc
index e99b6bc53dacb8f0ab2569d5d6eb01245446be93..796f265dccafe8424165030b2250b9e2d6efca1c 100644
--- a/sql/connection.cc
+++ b/sql/connection.cc
@@ -801,7 +801,9 @@ int Connection::OnSqliteError(int err, sql::Statement *stmt) {
              << ": " << GetErrorMessage();
 
   if (!error_callback_.is_null()) {
-    error_callback_.Run(err, stmt);
+    // Fire from a copy of the callback in case of reentry into

[erikwright (departed), 2013/07/05 19:16:55]

I would argue that this is a bug in Callback.

Should the storage _really_ be freed while invoking the method? I'd argue that
it should be temporarily add-ref'd.

Suggestion: ask ajwong@ for his opinion.

[Scott Hess - ex-Googler, 2013/07/08 21:15:35]

I had logged http://crbug.com/254584 , but since I've not seen any action on it
I'll follow up in case it hit a filter.

+    // re/set_error_callback().
+    ErrorCallback(error_callback_).Run(err, stmt);
     return err;
   }