Chromium Code Reviews

Issue 1772513003: No need to re-collect stylesheets for setting type StyleChange. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
dstockwell, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No need to re-collect stylesheets for setting type StyleChange. Style recalc for all frames necessary, though. Committed: https://crrev.com/34c8d6a5819463220c92875341f9ca187cc97fd1 Cr-Commit-Position: refs/heads/master@{#379763}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+4 lines, -1 line)
M third_party/WebKit/Source/core/dom/StyleChangeReason.h View 1 chunk +1 line, -0 lines 0 comments
M third_party/WebKit/Source/core/dom/StyleChangeReason.cpp View 1 chunk +1 line, -0 lines 0 comments
M third_party/WebKit/Source/core/page/Page.cpp View 2 chunks +2 lines, -1 line 0 comments

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772513003/1
4 years, 9 months ago (2016-03-07 15:46:14 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 17:00:11 UTC) #4
rune
4 years, 9 months ago (2016-03-07 19:21:37 UTC) #6
esprehn
lgtm
4 years, 9 months ago (2016-03-08 06:01:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772513003/1
4 years, 9 months ago (2016-03-08 06:01:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 06:06:38 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 06:08:00 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/34c8d6a5819463220c92875341f9ca187cc97fd1
Cr-Commit-Position: refs/heads/master@{#379763}

Powered by Google App Engine